crates/compiler-core/src/bytecode/instruction.rs (1)

32-35: Consider deriving PartialEq and Eq for the opcode enum.

The Opcode and PseudoOpcode enums only derive Clone, Copy, and Debug. Adding PartialEq and Eq would enable equality comparisons and pattern matching in match guards, which may be useful for consumers of these types.

💡 Suggested change

-        #[derive(Clone, Copy, Debug)]
+        #[derive(Clone, Copy, Debug, PartialEq, Eq)]
         pub enum $opcode_name {
             $($op_name),*
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/compiler-core/src/bytecode/instruction.rs` around lines 32 - 35, The
opcode enums only derive Clone, Copy, and Debug; add PartialEq and Eq to the
derive list so consumers can compare values and use match guards. Update the
macro-generated enum declarations (the $opcode_name expansion and the concrete
Opcode and PseudoOpcode enums) to include #[derive(Clone, Copy, Debug,
PartialEq, Eq)] so equality comparisons are available for those types.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

crates/compiler-core/src/bytecode/instruction.rs (1)

32-35: Consider adding PartialEq, Eq, and Hash derives to opcode enums.

The generated opcode enums (Opcode, PseudoOpcode) only derive Clone, Copy, Debug. Adding PartialEq, Eq, and optionally Hash would enable their use in comparisons and as map/set keys, which could be useful for opcode analysis or caching scenarios.

♻️ Suggested derive expansion

-        #[derive(Clone, Copy, Debug)]
+        #[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
         pub enum $opcode_name {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/compiler-core/src/bytecode/instruction.rs` around lines 32 - 35, The
generated opcode enums (the template enum named by $opcode_name, e.g., Opcode
and PseudoOpcode) only derive Clone, Copy, Debug; update the derive attribute to
also include PartialEq, Eq, and Hash so these enums can be compared and used as
map/set keys; modify the derive line in the enum generation template (the block
containing #[derive(Clone, Copy, Debug)] and pub enum $opcode_name { ... }) to
add PartialEq, Eq, Hash, and ensure both generated enums are adjusted
accordingly.

scripts/generate_opcode_metadata.py (2)

29-31: Minor naming consideration: function produces UPPER_SNAKE_CASE.

The function name to_snake_case typically implies lower_case_with_underscores, but this produces UPPER_CASE_WITH_UNDERSCORES. Consider renaming to to_screaming_snake_case or to_upper_snake_case for clarity.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/generate_opcode_metadata.py` around lines 29 - 31, The function
to_snake_case actually returns UPPER_SNAKE_CASE (screaming snake case); rename
it to something clear like to_screaming_snake_case or to_upper_snake_case and
update all call sites accordingly (search for to_snake_case references) and
adjust any docstrings/comments to reflect screaming/upper snake case behavior to
avoid confusion.

---

52-60: Consider adding defensive checks for regex matches.

Lines 53-54 call .group() and .groups() directly on regex results. If an entry doesn't match the expected pattern (e.g., due to format changes in instruction.rs), this will raise an AttributeError: 'NoneType' object has no attribute 'group', which can be confusing to debug.

💡 Suggested improvement for clearer error messages

             have_oparg = "Arg<" in entry  # Hacky but works
-            rust_name = re.match(r"(\w+)", entry).group(1)
-            id_num, cpython_name = re.search(r'\((\d+),\s*"([^"]+)"\)', entry).groups()
+            name_match = re.match(r"(\w+)", entry)
+            if not name_match:
+                raise ValueError(f"Could not parse Rust name from entry: {entry!r}")
+            rust_name = name_match.group(1)
+            
+            id_match = re.search(r'\((\d+),\s*"([^"]+)"\)', entry)
+            if not id_match:
+                raise ValueError(f"Could not parse (id, cpython_name) from entry: {entry!r}")
+            id_num, cpython_name = id_match.groups()
             yield cls(

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/generate_opcode_metadata.py` around lines 52 - 60, Add defensive
checks around the regex matches for rust_name and (id_num, cpython_name) so a
malformed entry does not cause a cryptic AttributeError: verify
re.match(r"(\w+)", entry) and re.search(r'\((\d+),\s*"([^"]+)"\)', entry)
returned non-None before calling .group()/.groups(), and if either is None raise
a clear ValueError that includes the offending entry string (and optional
context like the index or source filename) so callers of the generator (the
class constructor via cls(...), and variables have_oparg / rust_name) get a
descriptive error instead of NoneType attribute errors.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes