{{ message }}
docs: fixed misleading comment about the array method (forEach instead of reduce) used in AverageMean.js#1727
Merged
raklaptudirm merged 3 commits intoOct 16, 2024
Conversation
…d of reduce) used in AverageMean.js
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1727 +/- ##
==========================================
- Coverage 84.76% 84.76% -0.01%
==========================================
Files 378 378
Lines 19742 19738 -4
Branches 2955 2957 +2
==========================================
- Hits 16735 16731 -4
Misses 3007 3007 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Collaborator
|
Just remove the comment. It adds no value. |
Sorry, something went wrong.
…cessary operations.
appgurueu
reviewed
Oct 10, 2024
Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com>
appgurueu
approved these changes
Oct 10, 2024
anandfresh
approved these changes
Oct 11, 2024
raklaptudirm
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Describe your change:
what was wrong?
wrong array method in comment
Before:
After:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.