{{ message }}
refactor(schematics): remove unnecessary compileComponents#33082
Open
JeanMeche wants to merge 1 commit into
Open
refactor(schematics): remove unnecessary compileComponents#33082JeanMeche wants to merge 1 commit into
compileComponents#33082JeanMeche wants to merge 1 commit into
Conversation
angular/angular/pull/61230 updated `TestBed`'s behavior of components with async metadata. `TestBed` will now only throw when `overrideComponent()` is used on a component with a `@defer` block
e7e1739 to
f0927f1
Compare
April 28, 2026 19:48
There was a problem hiding this comment.
Code Review
This pull request removes unnecessary compileComponents() calls and associated async/await syntax from Angular unit test templates and test files. These changes affect application and component schematics, as well as existing unit tests, streamlining the test setup. A test case verifying the presence of compileComponents() was also removed to align with these changes. I have no feedback to provide.
Sorry, something went wrong.
cexbrayat
reviewed
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
angular/angular/pull/61230 updated
TestBed's behavior of components with async metadata.TestBedwill now only throw whenoverrideComponent()is used on a component with a@deferblock