◐ Shell
reader mode source ↗
Skip to content

Fix #1079: Use isEmpty() instead of size() == 0#1119

Merged
josemduarte merged 1 commit into
biojava:masterfrom
Pasjonat90D:fix/use-isempty-instead-of-size-#1079
Dec 8, 2025
Merged

Fix #1079: Use isEmpty() instead of size() == 0#1119
josemduarte merged 1 commit into
biojava:masterfrom
Pasjonat90D:fix/use-isempty-instead-of-size-#1079

Conversation

@Pasjonat90D

@Pasjonat90D Pasjonat90D commented Nov 30, 2025

Copy link
Copy Markdown
Contributor

Fixes #1079

@Pasjonat90D Pasjonat90D mentioned this pull request Nov 30, 2025
Closed
josemduarte
josemduarte approved these changes Nov 30, 2025
View reviewed changes

@josemduarte josemduarte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM thank you!

@Pasjonat90D

Pasjonat90D commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Hi,
It looks like the PR is still pending and hasn’t been merged by the CI/CD. Could you please rerun it? Everything seems fine on my side, but the pipeline seems to be stuck.

Thanks!

@josemduarte

josemduarte commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

I tried re-running but it failed again. It looks like a problem with the SCOP external resource. I'll try again later.

@josemduarte

josemduarte commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

I've run tests locally and it works fine. I'll merge it.

Hide details View details @josemduarte josemduarte merged commit 70e9a74 into biojava:master Dec 8, 2025
0 of 10 checks passed
@Pasjonat90D

Pasjonat90D commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for manually merging the PR. I’ve noticed the additional comments from @jlerbsc. If you would like, please reopen the ticket and assign it to me.

@josemduarte

josemduarte commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Good point, just reopened. It was closed automatically by github with this PR.

@jlerbsc

jlerbsc commented Dec 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @Pasjonat90D Have you tried using indepth to automatically fix these defects?

@Pasjonat90D

Pasjonat90D commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Hi @jlerbsc,
no, I used SonarQube to detect and fix them manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josemduarte josemduarte josemduarte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quality: Sonar S1155 "Collection.isEmpty()" should be used to test for emptiness

3 participants

@Pasjonat90D @josemduarte @jlerbsc