◐ Shell
reader mode source ↗
Skip to content

TestPreprocessor: removed usage of std::istringstream#6873

Merged
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:preproc-xxx-3
Aug 22, 2025
Merged

TestPreprocessor: removed usage of std::istringstream#6873
firewave merged 1 commit into
cppcheck-opensource:mainfrom
firewave:preproc-xxx-3

Conversation

@firewave

@firewave firewave commented Oct 7, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@firewave firewave marked this pull request as draft August 20, 2025 12:54
@firewave firewave changed the title TestPreprocessor: some cleanups Aug 20, 2025
@firewave firewave marked this pull request as ready for review August 20, 2025 13:05
@sonarqubecloud

sonarqubecloud Bot commented Aug 20, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

danmar
danmar approved these changes Aug 22, 2025
View reviewed changes

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I don't like it really. I feel you uglify/complicate the testcode.

@firewave

firewave commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator Author

I don't like it really. I feel you uglify/complicate the testcode.

It only "uglifies" the functions you call and in most cases it does not have much on the tests themselves. As seen in #6379 it helps with getting rid of unnecessary (slow) wrappers and overloads in the production code. I did not adjust tests where it really makes things worse.

There's also a simplecpp PR which makes things better.

Hide details View details @firewave firewave merged commit 90ee464 into cppcheck-opensource:main Aug 22, 2025
63 checks passed
@firewave firewave deleted the preproc-xxx-3 branch August 22, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmar danmar danmar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @danmar