Fix #13737 (GUI: should not timeout when premiumaddon takes more than 30 seconds)#7418
Conversation
|
CI is fixed - please rebase. |
Sorry, something went wrong.
Thanks! |
Sorry, something went wrong.
firewave
left a comment
There was a problem hiding this comment.
Please separate the crash fix into a different PR.
Sorry, something went wrong.
|
And did you intend to update the translation files? |
Sorry, something went wrong.
the ts files are updated behind my back whenever I compile the gui. if I am not supposed to commit that then it should be removed from the compilation. |
Sorry, something went wrong.
ok sure. |
Sorry, something went wrong.
We had that discussion many times before and I am still waiting on external feedback in #7020 to finally address this. |
Sorry, something went wrong.
basically I think it would make sense to go ahead with 7020 if that means we won't get ts updates every time we touch the gui. feel free to continue without the feedback. |
Sorry, something went wrong.
Alright. I will do a couple of more tests first so we do not miss something obvious. |
Sorry, something went wrong.
|
ticket for assertion failure: https://trac.cppcheck.net/ticket/13749 |
Sorry, something went wrong.
No description provided.