{{ message }}
even more testrunner cleanups#254
Merged
danmar merged 3 commits intoApr 13, 2022
Merged
Conversation
Collaborator
Sorry, something went wrong.
Collaborator
Author
|
@danmar Can this be merged? I need this to finish up that other PR. |
Sorry, something went wrong.
danmar
reviewed
Apr 11, 2022
danmar
reviewed
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This gets rid of all the explicit
std::istringstreamusage in the test cases so I can hopefully easily switch the implementation for the new API introduced with #244.