made it possible to create a TokenList from a buffer#347
Conversation
|
Still need to integrate/test it with #261 to make sure it does not introduce any issues. It is already actively used by |
Sorry, something went wrong.
|
Some tests are still failing - will investigate. |
Sorry, something went wrong.
|
The tests failing are the ones with binary characters in the string. We need to add an additional |
Sorry, something went wrong.
71a7916 to
32f1606
Compare
March 29, 2024 18:17
|
I changed it from a The tests pass but it produces valgrind failures in #261. |
Sorry, something went wrong.
32f1606 to
1895980
Compare
March 29, 2024 18:41
The issue has been fixed - see https://github.com/danmar/simplecpp/actions/runs/8484373804/job/23247192053?pr=261. |
Sorry, something went wrong.
|
I will provide a downstream PR which shows this is working within Cppcheck. We should also do the (planned) release before merging this. |
Sorry, something went wrong.
|
@firewave would you like that I release simplecpp now or do you have some more fixes..? |
Sorry, something went wrong.
|
Here is the downstream PR using char buffers instead of streams: cppcheck-opensource/cppcheck#6379. |
Sorry, something went wrong.
|
Ready for review since the downstream PR passes all tests. |
Sorry, something went wrong.
danmar
left a comment
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
|
@firewave you should have gotten an invite for this project. I hope you can merge.. |
Sorry, something went wrong.
@danmar Thanks. |
Sorry, something went wrong.
No description provided.