{{ message }}
fix #381#382
Closed
foryoung365 wants to merge 3 commits into
Closed
Conversation
Sorry, something went wrong.
firewave
reviewed
Oct 26, 2024
Collaborator
|
Thanks. Please give me a few days since I might be out sick. |
Sorry, something went wrong.
Collaborator
|
how do we test this? you can easily check if a file exists or not in a unit test but if you need to test various edge cases I guess a pytest working in a tempdir is better. |
Sorry, something went wrong.
Collaborator
|
The issue referenced here was fixed in #443. So I think this can be closed. And #339 contains improved code for checking for the existence of a file/directory. I also filed https://trac.cppcheck.net/ticket/14133 about detecting such code with Cppcheck. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
File existence check using fstream with ios::app is implemented as a workaround because: