{{ message }}
Fix #381 (When there are header files with the same name, the correct file cannot be found)#443
Merged
danmar merged 3 commits intoJun 16, 2025
Merged
Conversation
Contributor
Sorry, something went wrong.
Contributor
Author
|
Tests are failing due to an unrelated issue in testrunner where the |
Sorry, something went wrong.
Collaborator
I expect that you will look into it and make sure CI is green. |
Sorry, something went wrong.
danmar
reviewed
Jun 13, 2025
Collaborator
|
I feel that the testsuite folder should ideally be removed and that we move such tests to python instead. |
Sorry, something went wrong.
Contributor
Author
|
I've moved the tests to |
Sorry, something went wrong.
Hide details
View details
danmar
merged commit
danmar
merged commit 8e5c5f4
into
cppcheck-opensource:master
Jun 16, 2025
16 checks passed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The issue is caused by false matches in
getFileIdPath, which this fixes. This PR also adds two tests related to path resolution and matching, one for this particular issue of false positives and another one to detect false negatives on case-insensitive systems, which would result in#pragma oncebreaking. I added them both in this PR because they're related, but I can move the second test to another PR if that's preferable.