◐ Shell
reader mode source ↗
Skip to content

Switch to uncrustify#517

Merged
danmar merged 1 commit into
masterfrom
switch-to-uncrustify
Aug 28, 2025
Merged

Switch to uncrustify#517
danmar merged 1 commit into
masterfrom
switch-to-uncrustify

Conversation

@danmar

@danmar danmar commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@danmar

danmar commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator Author

@jcfr feel free to review

@jcfr jcfr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for working on this:

  1. Considering cherry picking commit titled chore: Remove obsolete runastyle scripts from #516

  2. Add a second commit

    chore: Add settings corresponding to uncrustify 0.80.1
    
    Introduce settings based of similar settings copied from 
    danmar/cppcheck@b4f07cdbb.
    
  3. Add a third commit:

    style: Consistent formatting of C++ sources using uncrustify
    
    This commit updates the sources file based on the settings
    introduced in previous commit.
    
  4. Either in the context of this pull request or in a follow-up one, add .git-blame-ignore-revs

  5. Add pre-commit.yml workflow with the uncrustify hook enabled.

Footnotes

@danmar danmar force-pushed the switch-to-uncrustify branch from 4f106fe to ecf23c1 Compare August 28, 2025 17:40
@danmar danmar force-pushed the switch-to-uncrustify branch from ecf23c1 to 18cfb6a Compare August 28, 2025 17:44
Hide details View details @danmar danmar merged commit cfd1797 into master Aug 28, 2025
26 checks passed
@danmar danmar deleted the switch-to-uncrustify branch August 28, 2025 17:49
@danmar

danmar commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator Author

@jcfr thanks for the reviews. there was some mess in my first commit to cleanup as you saw. but I hope it didn't add any extra changes now.

@jcfr

jcfr commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

The commit should probably have been split as suggested in #517 (review). Indeed, referencing 18cfb6a in .git-blame-ignore-revs will now incorrectly ignore non stylistic changes.

While this is not a critical in the current situation, in the future, I suggest to avoid mixing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants