Fix hang on UTF-16 LE BOM file#636
Conversation
|
Yeah - there's several places which lack checks for |
Sorry, something went wrong.
|
With #647 it should be possible to write a test which uses the input in question. |
Sorry, something went wrong.
Can we just run the tests with all three options? |
Sorry, something went wrong.
Yes, if somebody adds the functionality. It didn't seem straight forward to me so I haven't yet. Feel free to do so. |
Sorry, something went wrong.
|
I think I took a wrong turn. That should trigger with regular unit test. So please add a test for it. |
Sorry, something went wrong.
Ah - you mentioned |
Sorry, something went wrong.
|
So there is also some kind of platform divergence going on... |
Sorry, something went wrong.
|
These (hanging) runs may be cancelled by the way: |
Sorry, something went wrong.
Of course |
Sorry, something went wrong.
|
@chrchr-github I want to release simplecpp so we can update cppcheck repo before the release. do you want to merge now to get this into the release or rather wait? |
Sorry, something went wrong.
|
I have approved it, as far as I see it can be merged into the release. |
Sorry, something went wrong.
It's also a hang in cppcheck, so we might as well merge it (I don't have permission though). |
Sorry, something went wrong.
4ca0ee6
into
cppcheck-opensource:master
May 27, 2026
fixes #637