Drop unused 1bpp support from Stretch LCD code#792
Conversation
|
Hi Jakub, can you remember what is:
I don’t remember it. We added 2 years ago +- Did you test the branch with the brick? Here, you have an example to test that everything goes well: |
Sorry, something went wrong.
No, I don't currently have a free SD card (currently it is used by a non-robotic RPi, although I can reflash it later). I think I remember that Jessie used 1bpp packed black and white bitmaps and Stretch used 32bpp XRGB8888 bitmaps. However, because the Jessie codepath somehow didn't work, the old LCD implementation was copied over untouched and the new code is used only on Stretch (and Buster nowadays). |
Sorry, something went wrong.
9109c60 to
b736a39
Compare
January 10, 2021 21:43
|
Hi Jakub, did you test it? |
Sorry, something went wrong.
|
Not yet, and as such I have to close this PR. |
Sorry, something went wrong.
|
When you test in local, I will merge it. |
Sorry, something went wrong.
Related to #791