{{ message }}
feat: Add TLS support for Go Feature Server#6229
Merged
franciscojavierarceo merged 10 commits intoApr 14, 2026
Merged
Conversation
ntkathole
reviewed
Apr 11, 2026
Member
|
@shuchu optional nitpick - I see duplication of code in http vs https in start and serve methods |
Sorry, something went wrong.
Collaborator
Author
yes, you are right. let me put those two functions into one. |
Sorry, something went wrong.
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
franciscojavierarceo
approved these changes
Apr 14, 2026
Hide details
View details
franciscojavierarceo
merged commit
28a58d0
into
feast-dev:master
Apr 14, 2026
26 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
Add TLS support for users who have enterprise security requirement
Which issue(s) this PR fixes:
Fix #6095
Checks
git commit -s)Testing Strategy
Misc