◐ Shell
reader mode source ↗
Skip to content

feat: Add TLS support for Go Feature Server#6229

Merged
franciscojavierarceo merged 10 commits into
feast-dev:masterfrom
shuchu:feat/issue-6095
Apr 14, 2026
Merged

feat: Add TLS support for Go Feature Server#6229
franciscojavierarceo merged 10 commits into
feast-dev:masterfrom
shuchu:feat/issue-6095

Conversation

@shuchu

@shuchu shuchu commented Apr 5, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Add TLS support for users who have enterprise security requirement

Which issue(s) this PR fixes:

Fix #6095

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc


Open with Devin

@shuchu shuchu requested a review from a team as a code owner April 5, 2026 23:59
devin-ai-integration[bot]

This comment was marked as resolved.

@shuchu shuchu marked this pull request as draft April 6, 2026 00:36
@shuchu shuchu changed the title Add TLS support for Go Feature Server Apr 10, 2026
@shuchu shuchu marked this pull request as ready for review April 10, 2026 03:46
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@ntkathole

Copy link
Copy Markdown
Member

@shuchu optional nitpick - I see duplication of code in http vs https in start and serve methods

@shuchu

shuchu commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator Author

@shuchu optional nitpick - I see duplication of code in http vs https in start and serve methods

yes, you are right. let me put those two functions into one.

devin-ai-integration[bot]

This comment was marked as resolved.

@shuchu shuchu requested a review from ntkathole April 14, 2026 01:15
shuchu added 10 commits April 13, 2026 22:44
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Devin Review found 1 new potential issue.

View 13 additional findings in Devin Review.

Open in Devin Review

Hide details View details @franciscojavierarceo franciscojavierarceo merged commit 28a58d0 into feast-dev:master Apr 14, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TLS configuration support to Go feature server

3 participants