feat: Add optional 'org' in feature view (#6288)#6301
Conversation
6936cd9 to
1054d4a
Compare
April 20, 2026 21:38
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 Compiled Python protobuf files not regenerated after adding org field to FeatureView.proto (sdk/python/feast/protos/feast/core/FeatureView_pb2.py:22)
The .proto file adds string org = 19 to FeatureViewSpec, but the compiled Python protobuf files (FeatureView_pb2.py and FeatureView_pb2.pyi) were not regenerated. The FeatureView_pb2.pyi shows no ORG_FIELD_NUMBER, no org attribute, and no org parameter in __init__. The serialized descriptor in FeatureView_pb2.py still only covers fields up to version (field 18).
This causes runtime failures in two places:
to_proto_spec()atsdk/python/feast/feature_view.py:495passesorg=self.orgtoFeatureViewSpecProto(...), which will raiseValueErrorbecause the proto descriptor doesn't know aboutorg._from_proto_internal()atsdk/python/feast/feature_view.py:622andsdk/python/feast/feature_view.py:645readsfeature_view_proto.spec.org, which will raiseAttributeError.
This also violates the AGENTS.md rule: "Recompile protos after making changes to .proto files."
View 3 additional findings in Devin Review.
Sorry, something went wrong.
1c01636 to
e1b4786
Compare
April 25, 2026 02:06
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
e1b4786 to
9a94a3f
Compare
April 25, 2026 18:00
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
267cc27 to
b15ced3
Compare
April 25, 2026 19:39
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
5f518b7 to
63db9d5
Compare
April 28, 2026 01:06
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
ada98fe to
47119dd
Compare
April 28, 2026 04:12
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
🐛 1 issue in files not directly in the diff
🐛 Registry _update_metadata_fields does not update org, silently dropping org-only changes (sdk/python/feast/infra/registry/registry.py:549)
When a user changes only the org field of a feature view (without changing schema or UDF), _schema_or_udf_changed returns False (since none of the _schema_or_udf_changed overrides check org), so the code enters the _update_metadata_fields path at sdk/python/feast/infra/registry/registry.py:788. However, _update_metadata_fields updates description, tags, and owner (line 546-549) but never updates org. This means the org change is silently dropped during feast apply. The field is treated identically to owner everywhere else (constructor, __eq__, to_proto, from_proto, __copy__), so it should also be updated here alongside owner.
View 14 additional findings in Devin Review.
Sorry, something went wrong.
608b105
into
feast-dev:master
Apr 28, 2026
|
@nquinn408 seems unintentional, but to confirm all protos generated with older mypy-protobuf 2.x version ? |
Sorry, something went wrong.
edited by devin-ai-integration
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.