{{ message }}
feat: Make udf optional if agg defined (#5689)#6328
Merged
nquinn408 merged 6 commits intoApr 25, 2026
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
nquinn408
force-pushed
the
optional-udf-if-agg
branch
from
16ebe3a to
0524b4d
Compare
April 24, 2026 21:11
Fixes ruff I001 import ordering violation introduced with the aggregations-without-udf test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
nquinn408
force-pushed
the
optional-udf-if-agg
branch
from
0524b4d to
f64c1cb
Compare
April 24, 2026 21:11
_parse_transformation_from_proto fell through to _handle_backward_compatible_udf when feature_transformation was absent, crashing on dill.loads(b"") for ODFVs that have no transformation but do have aggregations. Return None early when transformation_type is None and proto.spec.aggregations is non-empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
infer_features() unconditionally asserted feature_transformation is not None, crashing during apply() for aggregation-only ODFVs. Add an early return when aggregations are present and feature_transformation is None; features are explicitly declared via schema so inference via transformation execution is not needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
- Redirect feast.types.Value_pb2 stub imports to
feast.protos.feast.types.Value_pb2 where typed .pyi stubs live
- Add # type: ignore[arg-type] where .value (int) is passed to a
proto field typed as NewType("ValueType", int)
- Add # type: ignore[arg-type] for getattr call with Optional[str]
from WhichOneof in remote.py
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
nquinn408
force-pushed
the
optional-udf-if-agg
branch
from
bb086b5 to
c7838e6
Compare
April 24, 2026 23:55
HaoXuAI
approved these changes
Apr 25, 2026
HaoXuAI
left a comment
HaoXuAI
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
ntkathole
reviewed
Apr 25, 2026
Member
|
also, docstring change for aggregation or docs addition for the change - https://github.com/feast-dev/feast/blob/master/sdk/python/feast/on_demand_feature_view.py#L211 |
Sorry, something went wrong.
Hide details
View details
nquinn408
merged commit
nquinn408
merged commit f630056
into
feast-dev:master
Apr 25, 2026
43 of 47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
edited by devin-ai-integration
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.