{{ message }}
feat: Bump redis-py version cap from <5 to <8#6339
Merged
ntkathole merged 2 commits intoMay 1, 2026
Merged
Conversation
Member
|
@neolunar7 can you also run |
Sorry, something went wrong.
The redis-py dependency was pinned to <5, which prevented downstream servers using Feast from upgrading to redis-py 5+. The redis-py APIs used by Feast (Redis, RedisCluster, Sentinel, pipeline, hset, hmget, hgetall, scan_iter, delete, hdel, expire) are fully compatible across v4 through v7. Also bumps hiredis cap from <3 to <4 since redis-py 5+ requires hiredis>=3.0 when the hiredis extra is used. Signed-off-by: neolunar7 <piljae@rapportlabs.kr> Signed-off-by: neolunar7 <neolunar7@gmail.com>
efbb4ac to
1b4e643
Compare
May 1, 2026 06:56
Contributor
Author
|
@ntkathole I've added the relevant files too, thanks :) |
Sorry, something went wrong.
Signed-off-by: neolunar7 <neolunar7@gmail.com>
1b4e643 to
b336ae5
Compare
May 1, 2026 07:29
ntkathole
approved these changes
May 1, 2026
Hide details
View details
ntkathole
merged commit
9538180
into
feast-dev:master
May 1, 2026
25 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Summary
redisdependency from>=4.2.2,<5to>=4.2.2,<8hiredisdependency from>=2.0.0,<3to>=2.0.0,<4Motivation
The current
redis<5pin prevents downstream servers that depend on Feast from using redis-py 5+. Since redis-py is now at version 7.4.0, this is an increasingly painful constraint for users who need newer redis-py features or have other dependencies requiring redis-py 5+.Compatibility Analysis
Feast uses only one file that imports redis (
sdk/python/feast/infra/online_stores/redis.py). The APIs used are all stable across v4 through v7:Redis,RedisCluster,Sentinelclient classesredis.asynciomodule (Redis, RedisCluster, Sentinel)pipeline(),hset(),hmget(),hgetall(),scan_iter(),delete(),hdel(),expire()All imports and method signatures are unchanged from redis-py 4.x to 7.x.
The
hirediscap is bumped from<3to<4because redis-py 5+ requireshiredis>=3.0when the hiredis extra is used.Test plan
daskdep in test fixture)