{{ message }}
GitBook: [#1] Plugin standards documentation#2011
Merged
feast-ci-bot merged 2 commits intoNov 11, 2021
Merged
Conversation
Collaborator
Sorry, something went wrong.
felixwang9817
requested review from
a team,
achals,
adchia,
tsotnet and
woop
as code owners
November 9, 2021 22:47
adchia
approved these changes
Nov 9, 2021
adchia
left a comment
adchia
left a comment
Collaborator
There was a problem hiding this comment.
/lgtm
Sorry, something went wrong.
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
force-pushed
the
master
branch
from
127837c to
ca8a6a8
Compare
November 11, 2021 18:21
adchia
approved these changes
Nov 11, 2021
adchia
left a comment
adchia
left a comment
Collaborator
There was a problem hiding this comment.
/lgtm
Sorry, something went wrong.
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it: This PR adds documentation on the standards for plugin repos.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: