@@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from collections import defaultdict
from datetime import datetime, timezone
from typing import (
@@ -297,7 +298,7 @@ def _type_err(item, dtype):
        None,
    ),
    ValueType.FLOAT: ("float_val", lambda x: float(x), None),
-    ValueType.DOUBLE: ("double_val", lambda x: x, {float, np.float64}),
    ValueType.STRING: ("string_val", lambda x: str(x), None),
    ValueType.BYTES: ("bytes_val", lambda x: x, {bytes}),
    ValueType.BOOL: ("bool_val", lambda x: x, {bool, np.bool_, int, np.int_}),
@@ -353,6 +354,19 @@ def _python_value_to_proto_value(
                feast_value_type
            ]

            if sample is not None and not all(
                type(item) in valid_types for item in sample
            ):
@@ -631,6 +645,7 @@ def redshift_to_feast_value_type(redshift_type_as_str: str) -> ValueType:
        "varchar": ValueType.STRING,
        "timestamp": ValueType.UNIX_TIMESTAMP,
        "timestamptz": ValueType.UNIX_TIMESTAMP,
        # skip date, geometry, hllsketch, time, timetz
    }


@@ -48,3 +48,35 @@ def test_python_values_to_proto_values_bool(values):
    converted = feast_value_type_to_python_type(protos[0])

    assert converted is bool(values[0])
Original file line number	Diff line number	Diff line change
Expand Up		@@ -48,3 +48,35 @@ def test_python_values_to_proto_values_bool(values):
		converted = feast_value_type_to_python_type(protos[0])

		assert converted is bool(values[0])