◐ Shell
reader mode source ↗
Skip to content

chore: Support pandas 2#3928

Closed
sudohainguyen wants to merge 5 commits into
feast-dev:masterfrom
sudohainguyen:deps
Closed

chore: Support pandas 2#3928
sudohainguyen wants to merge 5 commits into
feast-dev:masterfrom
sudohainguyen:deps

Conversation

@sudohainguyen

@sudohainguyen sudohainguyen commented Feb 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Relax pandas upper bound to support v2.0

Which issue(s) this PR fixes:

Fixes #3709

Additional changes:

Set upper bound for moto due to its recent breaking changes in 5.0.0

@sudohainguyen sudohainguyen force-pushed the deps branch 3 times, most recently from 095047b to b321bfa Compare February 4, 2024 13:00
@sudohainguyen sudohainguyen requested a review from shuchu February 4, 2024 13:46
@sudohainguyen

sudohainguyen commented Feb 4, 2024

Copy link
Copy Markdown
Collaborator Author

pending on #3925
cc: @franciscojavierarceo

@sudohainguyen

sudohainguyen commented Feb 5, 2024

Copy link
Copy Markdown
Collaborator Author

seems the issue appears in integration tests related to this issue from pandas pandas-dev/pandas#55730

we need to pin pandas version to at least 2.1.3 in order to adopt pandas v2, however the library only supports python 3.8 till 2.0.3

@sudohainguyen

sudohainguyen commented Feb 5, 2024

Copy link
Copy Markdown
Collaborator Author

Note: just run local integration tests successfully on python 3.10, pandas 2.2.0
however it's not possible to make python 3.8 + pandas 2 + feast work together, if users install py 3.8 with feast, they shall not use pandas v2

@sudohainguyen sudohainguyen mentioned this pull request Feb 5, 2024
Merged
HaoXuAI
HaoXuAI approved these changes Feb 6, 2024
View reviewed changes

@HaoXuAI HaoXuAI left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

nicee!

@sudohainguyen

sudohainguyen commented Feb 6, 2024

Copy link
Copy Markdown
Collaborator Author

still err, hang on, working on it

@sudohainguyen sudohainguyen added the dependencies Pull requests that update a dependency file label Feb 11, 2024
@sudohainguyen
chore: Support pandas 2 …
c7059ce 
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
@sudohainguyen
chore: Generate reqs for py38 and py39 …
94036fd 
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
@sudohainguyen
fix: Update imports in mysql unit test …
3a5011b 
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
@sudohainguyen
fix: Set upper bound for moto …
83b1160 
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
@sudohainguyen
fix: Recompile ci deps py38 py39 …
09bdff6 
Signed-off-by: Hai Nguyen <quanghai.ng1512@gmail.com>
@sudohainguyen sudohainguyen mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoXuAI HaoXuAI HaoXuAI approved these changes

@shuchu shuchu

@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pandas 2.0 support

3 participants

@sudohainguyen @HaoXuAI @franciscojavierarceo