{{ message }}
chore: Refactoring to fix mypy linting#3947
Closed
bushwhackr wants to merge 13 commits into
Closed
Conversation
658354f to
275d162
Compare
February 11, 2024 18:24
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
275d162 to
f0f7fec
Compare
February 11, 2024 18:26
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
bushwhackr
commented
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it: mypy lint fixes, refer to: #3938
subset of mypy linting fixes when mypy version was upgraded in #3938.
The PR is getting alittle too long, so I'm breaking into another PR for the final fixes.
Which issue(s) this PR fixes:
Fixes #