{{ message }}
feat: Feature/upgrade 3.11 and remove bytewax#4046
Closed
lokeshrangineni wants to merge 26 commits into
Closed
Conversation
Contributor
Sorry, something went wrong.
…pendencies. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
…hould fix the failure of python unit test cases. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
…-bytewax # Conflicts: # sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_engine.py
Contributor
Author
|
I am looking at the PR again to modify the the logic without actually removing the bytewax engine. If this approach works then probably i will update the PR otherwise we can go ahead with this approach. |
Sorry, something went wrong.
This was referenced Apr 9, 2024
…1-remove-bytewax # Conflicts: # .github/workflows/build_wheels.yml # .github/workflows/nightly-ci.yml # .github/workflows/unit_tests.yml # sdk/python/feast/infra/materialization/kubernetes/Dockerfile # sdk/python/feast/infra/materialization/kubernetes/k8s_materialization_engine.py # sdk/python/feast/infra/materialization/kubernetes/k8s_materialization_job.py # sdk/python/feast/infra/materialization/kubernetes/k8s_materialization_task.py # sdk/python/feast/infra/materialization/kubernetes/main.py # setup.py
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> This reverts commit 4bec6b0.
…dev#4140) * chore: Move feast install to docker build in java it tests (feast-dev#4126) * chore: Move feast install to docker build in java it tests Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove commented out lines in compose file Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * make local compose mode default Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * limit COPY contents Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove requirements.txt from java tests docker image Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * include pyproject.toml in dockerfile Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * change links to depends_on Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * try updating setup-python to v5 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * pin macos image to macos-12 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * force rerun Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * chore: Incorporate release 0.37.1 to master (feast-dev#4127) * chore(release): release 0.37.1 ## [0.37.1](feast-dev/feast@v0.37.0...v0.37.1) (2024-04-17) ### Bug Fixes * Pgvector patch ([feast-dev#4108](feast-dev#4108)) ([1a1f0b1](feast-dev@1a1f0b1)) ### Reverts * Reverts "fix: Using version args to install the correct feast version" ([feast-dev#4112](feast-dev#4112)) ([d5ded69](feast-dev@d5ded69)), closes [feast-dev#3953](feast-dev#3953) * chore: Move feast install to docker build in java it tests (feast-dev#4126) * chore: Move feast install to docker build in java it tests Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove commented out lines in compose file Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * make local compose mode default Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * limit COPY contents Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove requirements.txt from java tests docker image Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * include pyproject.toml in dockerfile Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * change links to depends_on Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * try updating setup-python to v5 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * pin macos image to macos-12 Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * force rerun Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> Co-authored-by: feast-ci-bot <feast-ci-bot@willem.co> Co-authored-by: Tornike Gurgenidze <togurg14@freeuni.edu.ge> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * chore: Install python dependencies with uv in workflows (feast-dev#4086) * install dependencies in unit-tests with uv Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * install dependencies in unit-tests with uv Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * enable caching, change linter job Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * change local integration tests to uv Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * change all installs to uv Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * try adding uv cache Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * fix lambda cache step name Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * reenable caches for uv Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * remove dangling cache step Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * feat: Make arrow primary interchange for online ODFV execution (feast-dev#4143) * rewrite online flow to use transform_arrow Signed-off-by: tokoko <togurg14@freeuni.edu.ge> * fix transformation server Signed-off-by: tokoko <togurg14@freeuni.edu.ge> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * feat: Feast/IKV online store documentation (feast-dev#4146) * feat: Feast/IKV online store documentation Signed-off-by: Pushkar Gupta <pushkar.moi@gmail.com> * functionality matric Signed-off-by: Pushkar Gupta <pushkar.moi@gmail.com> * more changes Signed-off-by: Pushkar Gupta <pushkar.moi@gmail.com> * mount dir Signed-off-by: Pushkar Gupta <pushkar.moi@gmail.com> --------- Signed-off-by: Pushkar Gupta <pushkar.moi@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * fix: Default value is not set in Redis connection string using environment variable (feast-dev#4136) Removed documentation of Redis connection string supporting default values when using environment variables as it isn't supported Fixes feast-dev#3669 Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * fix: Make sure schema is used when calling `get_table_query_string` method for Snowflake datasource (feast-dev#4131) * Fix get_table_query_string method for Snowflake datasource Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com> * Add quotes to table string Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com> --------- Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * fix: Change checkout action back to v3 from v5 which isn't released yet (feast-dev#4147) Signed-off-by: Jeremy Ary <jary@redhat.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * changed the code the way mysql container is initialized. Trying to fix the issue - feast-dev#4128 Also going to check if this change will be resolved in the github actions as well. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * reformatted the file to resolve lint error. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> * reformatted the file to resolve lint error. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> --------- Signed-off-by: tokoko <togurg14@freeuni.edu.ge> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Pushkar Gupta <pushkar.moi@gmail.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com> Signed-off-by: TomSteenbergen <tomsteenbergen1995@gmail.com> Signed-off-by: Jeremy Ary <jary@redhat.com> Co-authored-by: Tornike Gurgenidze <togurg14@freeuni.edu.ge> Co-authored-by: Jeremy Ary <jary@redhat.com> Co-authored-by: feast-ci-bot <feast-ci-bot@willem.co> Co-authored-by: Pushkar Gupta <pushkar.moi@gmail.com> Co-authored-by: Theodor Mihalache <84387487+tmihalac@users.noreply.github.com> Co-authored-by: Tom Steenbergen <41334387+TomSteenbergen@users.noreply.github.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> This reverts commit 8d77135.
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
lokeshrangineni
force-pushed
the
feature/upgrade-3.11-remove-bytewax
branch
from
279b043 to
bada729
Compare
April 25, 2024 21:07
jeremyary
reviewed
Apr 26, 2024
Collaborator
|
@lokeshrangineni looking really good, appreciate the diligence, I know you've been sticking with this one for a while! |
Sorry, something went wrong.
update doc Signed-off-by: cmuhao <sduxuhao@gmail.com>
…pendencies. Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com> This reverts commit 8d77135.
Signed-off-by: Lokesh Rangineni <lokeshforjava@gmail.com>
lokeshrangineni
requested review from
a team,
DvirDukhan,
kevjumba,
niklasvm,
sfc-gh-madkins,
sudohainguyen and
younggyu-oh
as code owners
April 29, 2024 16:08
…e/upgrade-3.11-remove-bytewax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #