{{ message }}
chore: Adding more tests for On Demand Feature Views#4069
Merged
franciscojavierarceo merged 9 commits intoApr 4, 2024
Merged
Conversation
Member
Sorry, something went wrong.
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
tokoko
reviewed
Apr 4, 2024
tokoko
reviewed
Apr 4, 2024
… on a list Signed-off-by: Francisco Javier Arceo <franciscojavierarceo@users.noreply.github.com>
tokoko
approved these changes
Apr 4, 2024
tokoko
left a comment
tokoko
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jeremyary
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
This PR adds explicit tests for
get_online_featuresfor the on demand feature views for Python and Pandas transformations. It also fixes a bug when serializing the transformation into a protobuf object.Which issue(s) this PR fixes:
Fixes bug in serializing Python Native transformation object into Pandas Transformation.
Fixes