fix: Bad feature_servers/multicloud Dockerfile#4138
Conversation
820ef16 to
0e22da4
Compare
April 23, 2024 16:13
$ export VERSION=0.37.1
$ export REGISTRY=docker.io
$ make build-feature-server-docker
[+] Building 95.1s (14/14) FINISHED docker:default
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 1.44kB 0.0s
=> [internal] load metadata for docker.io/library/python:3.9-slim 0.9s
...
...
=> exporting to image 3.6s
=> => exporting layers 3.6s
=> => writing image sha256:7cd5076b1023823d01b98297b06544f2ab52964aa6c690ba6b2e8492a841decf 0.0s
=> => naming to docker.io/library/feature-server:0.37.1
$ docker run -it docker.io/library/feature-server:0.37.1 pip show feast | grep Version
Version: 0.37.1.dev16+g0e22da42.d20240423 |
Sorry, something went wrong.
|
Thanks! We'll take a look. As far as use case goes (as far as I understand), it's a stretch to imagine an end user utilizing every cloud provider we enable, but this checks the box for ensuring whatever variant of subsets a user plugs in are good to go together. |
Sorry, something went wrong.
|
any blockers? |
Sorry, something went wrong.
|
@bushwhackr apologies for taking a bit of time. We've had a backlog to work through after resolving our release process issues, so I'm slowly catching us up on PR's. If you wouldn't mind TAL at currrent conflicts, I'll work to bring in your change for our next release. Thanks again for your time spent here & contributions! |
Sorry, something went wrong.
|
i believe this is used during our deployment to verify the build |
Sorry, something went wrong.
|
I believe the original Dockerfile (with pypi installation) still useful while the users want to test official Feast releases. |
Sorry, something went wrong.
ah, I know the problem. In the document, Development Guide part. The last step of Environment setup is: As a result, it will call the pypi version.... |
Sorry, something went wrong.
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
Signed-off-by: Chester Ong <chester.ong.ch@gmail.com>
0e22da4 to
015da38
Compare
May 29, 2024 09:57
What this PR does / why we need it:
Multicloud dockerfile is not consistent with the rest of the infra/feature_servers in that it pulls pypi feast package. Whilst others uses the repository code to build feast.
This PR seeks to standardise it so that we are not reliant on the pypi feast package.
NOTE: I am not a user of multicloud feast and do not understand its use case. The Dockerfile I created is based on my observation on what the incumbent was doing.
Which I understood as the following:
I would need clarification on what is the purpose of this Docker image.
Which issue(s) this PR fixes:
#4135, Related: #3953
Fixes