◐ Shell
reader mode source ↗
Skip to content
Merged

feat: Instrument Feast using Prometheus and OpenTelemetry #4366

Show file tree
Hide file tree
Changes from all commits
File filter
Conversations
Jump to
Diff view
Apply and reload
Show whitespace
Diff view
Apply and reload
3 changes: 1 addition & 2 deletions README.md
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
[![GitHub Release](https://img.shields.io/github/v/release/feast-dev/feast.svg?style=flat&sort=semver&color=blue)](https://github.com/feast-dev/feast/releases)

## Join us on Slack!

👋👋👋 [Come say hi on Slack!](https://join.slack.com/t/feastopensource/signup)

## Overview
Expand Down Expand Up @@ -231,4 +230,4 @@ Thanks goes to these incredible people:

<a href="https://github.com/feast-dev/feast/graphs/contributors">
<img src="https://contrib.rocks/image?repo=feast-dev/feast" />
</a>
4 changes: 4 additions & 0 deletions infra/charts/feast-feature-server/README.md
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,12 @@ See [here](https://github.com/feast-dev/feast/tree/master/examples/python-helm-d
| imagePullSecrets | list | `[]` | |
| livenessProbe.initialDelaySeconds | int | `30` | |
| livenessProbe.periodSeconds | int | `30` | |
| nameOverride | string | `""` | |
| nodeSelector | object | `{}` | |
| podAnnotations | object | `{}` | |
| podSecurityContext | object | `{}` | |
| readinessProbe.initialDelaySeconds | int | `20` | |
Expand Down
19 changes: 19 additions & 0 deletions infra/charts/feast-feature-server/samples/instrumentation.yaml
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
16 changes: 16 additions & 0 deletions infra/charts/feast-feature-server/samples/otel-sm.yaml
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
15 changes: 15 additions & 0 deletions infra/charts/feast-feature-server/samples/prometheus.yaml
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
16 changes: 16 additions & 0 deletions infra/charts/feast-feature-server/samples/service-monitor.yaml
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Binary file added infra/charts/feast-feature-server/samples/workflow.png
View file Edit file Delete file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 12 additions & 1 deletion infra/charts/feast-feature-server/templates/deployment.yaml
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ spec:
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
{{- include "feast-feature-server.selectorLabels" . | nindent 8 }}
Expand Down Expand Up @@ -48,10 +51,18 @@ spec:
- "feast"
- "serve_registry"
{{- else }}
- "feast"
- "serve"
- "-h"
- "0.0.0.0"
{{- end }}
ports:
- name: {{ .Values.feast_mode }}
Expand Down Expand Up @@ -88,4 +99,4 @@ spec:
{{- with .Values.tolerations }}
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
6 changes: 6 additions & 0 deletions infra/charts/feast-feature-server/templates/service.yaml
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,11 @@ spec:
targetPort: {{ .Values.feast_mode }}
protocol: TCP
name: http
selector:
{{- include "feast-feature-server.selectorLabels" . | nindent 4 }}
Loading
Toggle all file notes Toggle all file annotations