Looks like integration tests are failing?

seems passed now

This will break any imports users are doing with custom code, can you update or title?

This will break any imports users are doing with custom code, can you update or title?

There should be non-breaking changes, I also added the old custom type as well.

This will break any imports users are doing with custom code, can you update or title?

There should be non-breaking changes, I also added the old custom type as well.

I think he's saying that any feature store definition importing the legacy modules would be broken, e.g.:

>> import feast.infra.online_stores.contrib.hazelcast_online_store.hazelcast_online_store
...
ModuleNotFoundError: No module named 'feast.infra.online_stores.contrib.hazelcast_online_store.hazelcast_online_store'

Why don't you create aliases instead, with a warning to inform the user that these will be removed later?

# feast/infra/online_stores/contrib/qdrant.py

import warnings
from feast.infra.online_stores.cqdrant import QdrantOnlineStore

warnings.warn(
    "The module feast.infra.online_stores.contrib.qdrant is deprecated and will be removed in a future release. "
    "Please use feast.infra.online_stores.cqdrant instead.",
    DeprecationWarning,
    stacklevel=2,
)

This will break any imports users are doing with custom code, can you update or title?

There should be non-breaking changes, I also added the old custom type as well.

I think he's saying that any feature store definition importing the legacy modules would be broken, e.g.:

>> import feast.infra.online_stores.contrib.hazelcast_online_store.hazelcast_online_store
...
ModuleNotFoundError: No module named 'feast.infra.online_stores.contrib.hazelcast_online_store.hazelcast_online_store'

Why don't you create aliases instead, with a warning to inform the user that these will be removed later?

# feast/infra/online_stores/contrib/qdrant.py

import warnings
from feast.infra.online_stores.cqdrant import QdrantOnlineStore

warnings.warn(
    "The module feast.infra.online_stores.contrib.qdrant is deprecated and will be removed in a future release. "
    "Please use feast.infra.online_stores.cqdrant instead.",
    DeprecationWarning,
    stacklevel=2,
)

Creating a alias means I have to keep two folders for same store. I think that's more confusing.
Since the online_store are not meant to be used by user to directly import the module, I think it's ok to simply remove the old ones.

@franciscojavierarceo @dmartinol fixed the conflict after new online store, need another review.