{{ message }}
chore: Upgrade TypeScript to latest version 5.7.2 in /ui#4788
Merged
dmartinol merged 1 commit intoDec 1, 2024
Merged
Conversation
Contributor
Sorry, something went wrong.
shuchu
approved these changes
Nov 25, 2024
shuchu
left a comment
shuchu
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Lock the TypeScript minor version by using `~` instead of `^` in the version specifier, see fastify/fastify-type-provider-typebox#169 (comment). After upgrading, the TypeScript compiler complained that the `long` package has no default export. Related fixes: - Add the latest `long` version as a direct dependency since our code uses it directly; no compilation errors with the latest version - The `long` package exports a `Long` class, so use a capital first letter in the import name to match that Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
peruukki
force-pushed
the
ui-typescript-5
branch
from
2c8e585 to
9fac206
Compare
November 28, 2024 06:26
Contributor
Author
|
Could I get someone to merge this? 🙏 |
Sorry, something went wrong.
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Dec 2, 2024
) Lock the TypeScript minor version by using `~` instead of `^` in the version specifier, see fastify/fastify-type-provider-typebox#169 (comment). After upgrading, the TypeScript compiler complained that the `long` package has no default export. Related fixes: - Add the latest `long` version as a direct dependency since our code uses it directly; no compilation errors with the latest version - The `long` package exports a `Long` class, so use a capital first letter in the import name to match that Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
Dec 3, 2024
) Lock the TypeScript minor version by using `~` instead of `^` in the version specifier, see fastify/fastify-type-provider-typebox#169 (comment). After upgrading, the TypeScript compiler complained that the `long` package has no default export. Related fixes: - Add the latest `long` version as a direct dependency since our code uses it directly; no compilation errors with the latest version - The `long` package exports a `Long` class, so use a capital first letter in the import name to match that Signed-off-by: Harri Lehtola <peruukki@hotmail.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
Upgrade TypeScript to latest version 5.7.2. This gets rid of the
@elastic/eui@95.12.0" has incorrect peer dependency "typescript@~4.5.3 || ^5"warning when installing Feast UI dependencies:Also lock the TypeScript minor version by using
~instead of^in the version specifier, see fastify/fastify-type-provider-typebox#169 (comment).Which issue(s) this PR fixes:
None.
Misc
After upgrading, the TypeScript compiler complained that the
longpackage had no default export. Related fixes:longversion as a direct dependency since our code uses it directly; no compilation errors with the latest versionlongpackage exports aLongclass, so use a capital first letter in the import name to match that