{{ message }}
chore: Issue warning announcing entity's value_type as mandatory #4833
Merged
dmartinol merged 2 commits intoDec 11, 2024
Merged
Conversation
Member
Sorry, something went wrong.
- Add deprecation warning when value_type is not specified for an entity - Add test cases to verify deprecation warning behavior - Prepare for making value_type mandatory in next release Issue: feast-dev#4670 Co-Authored-By: Francisco Javier Arceo <arceofrancisco@gmail.com> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- Reorder imports according to PEP8 - Group standard library imports together - Fix ruff linting issues Co-Authored-By: Francisco Javier Arceo <arceofrancisco@gmail.com> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
dmartinol
reviewed
Dec 11, 2024
dmartinol
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
Make value_type for Entity issue a warning if not set. Next release we'll make it mandatory.
Which issue(s) this PR fixes:
#4670
Misc