◐ Shell
reader mode source ↗
Skip to content

test: Added upgrade tests#5072

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
tmihalac:upgrade-tests
Feb 25, 2025
Merged

test: Added upgrade tests#5072
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
tmihalac:upgrade-tests

Conversation

@tmihalac

@tmihalac tmihalac commented Feb 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added feast go operator upgrade tests

What this PR does / why we need it:

Tests backward compatibility of the CR

There are 2 new test suites with new make targets:
test-previous-version - Deploys the previous version operator and feast server, applies the previous version CRs and runs the e2e test
test-upgrade - Deploys the previous version operator and feast server, applies the current CRs and runs the e2e test

Those tests are run in the integration test github action right after the make test-e2e target

@tmihalac

tmihalac commented Feb 19, 2025

Copy link
Copy Markdown
Contributor Author

Please have a look I've split the pervious version test and the upgrade version test into 2 test suites, so I might call them from the OpenshiftCI @tchughesiv @lokeshrangineni @redhatHameed

@tmihalac tmihalac changed the title Added upgrade tests Feb 19, 2025
@tmihalac tmihalac force-pushed the upgrade-tests branch 4 times, most recently from 8daf89c to 298306c Compare February 19, 2025 14:23
@tmihalac tmihalac force-pushed the upgrade-tests branch 15 times, most recently from fc73482 to b23a78a Compare February 19, 2025 19:14
@tmihalac tmihalac marked this pull request as ready for review February 20, 2025 15:03
@tmihalac tmihalac requested a review from a team as a code owner February 20, 2025 15:03
@redhatHameed

redhatHameed commented Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@tmihalac few minor questions

  1. Are the upgrade tests set to run during the Feast release process, or every pull request?
  2. What will happened if test fails will this block releases ?

@tmihalac

tmihalac commented Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@tmihalac few minor questions

  1. Are the upgrade tests set to run during the Feast release process, or every pull request?
  2. What will happened if test fails will this block releases ?

@redhatHameed I've added them to the e2e github action which runs on:

  push:
    branches:
      - main
  pull_request:
    types:
      - opened
      - synchronize
      - labeled```

@tmihalac tmihalac requested a review from tchughesiv February 20, 2025 20:17
21 hidden items Load more…
@tmihalac
Added upgrade tests …
26f7b89 
Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
@lokeshrangineni lokeshrangineni mentioned this pull request Feb 25, 2025
Closed
@franciscojavierarceo franciscojavierarceo merged commit d1bf58f into feast-dev:master Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lokeshrangineni lokeshrangineni lokeshrangineni approved these changes

@tchughesiv tchughesiv Awaiting requested review from tchughesiv

@redhatHameed redhatHameed Awaiting requested review from redhatHameed

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmihalac @redhatHameed @tchughesiv @lokeshrangineni @franciscojavierarceo