{{ message }}
feat: Qdrant online store add retrieve_online_documents_v2#5211
Open
YassinNouh21 wants to merge 6 commits into
Open
feat: Qdrant online store add retrieve_online_documents_v2#5211YassinNouh21 wants to merge 6 commits into
retrieve_online_documents_v2#5211YassinNouh21 wants to merge 6 commits into
Conversation
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
HaoXuAI
reviewed
Apr 2, 2025
Collaborator
Author
|
@HaoXuAI I think Qdrant instance isn't defined in e2e |
Sorry, something went wrong.
YassinNouh21
commented
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
This PR enhances the Qdrant online store implementation with improved type safety and error handling in the
retrieve_online_documents_v2method. The changes include:These changes make the Qdrant online store more robust and type-safe, while maintaining backward compatibility with existing functionality.
Which issue(s) this PR fixes:
Fixes #5115
Misc
Key improvements in this PR:
cast()from typing moduleThe changes have been tested with both unit tests and integration tests to ensure backward compatibility and proper functionality.
@feast-dev/online-store-maintainers