◐ Shell
reader mode source ↗
Skip to content

feat: Qdrant online store add retrieve_online_documents_v2#5211

Open
YassinNouh21 wants to merge 6 commits into
feast-dev:masterfrom
YassinNouh21:feat/qdrant-retrieve-online-documents-v2
Open

feat: Qdrant online store add retrieve_online_documents_v2#5211
YassinNouh21 wants to merge 6 commits into
feast-dev:masterfrom
YassinNouh21:feat/qdrant-retrieve-online-documents-v2

Conversation

@YassinNouh21

@YassinNouh21 YassinNouh21 commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

This PR enhances the Qdrant online store implementation with improved type safety and error handling in the retrieve_online_documents_v2 method. The changes include:

  1. Added proper type annotations and casting for entity keys and feature values
  2. Improved error handling for timestamp parsing and value decoding
  3. Enhanced null checks and type validation throughout the method
  4. Added support for text-based search with fallback mechanisms

These changes make the Qdrant online store more robust and type-safe, while maintaining backward compatibility with existing functionality.

Which issue(s) this PR fixes:

Fixes #5115

Misc

Key improvements in this PR:

  • Added explicit type casting using cast() from typing module
  • Improved error handling for base64 decoding and timestamp parsing

The changes have been tested with both unit tests and integration tests to ensure backward compatibility and proper functionality.

@feast-dev/online-store-maintainers

Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
@YassinNouh21 YassinNouh21 requested a review from a team as a code owner April 2, 2025 16:46
@YassinNouh21

YassinNouh21 commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator Author

@HaoXuAI I think Qdrant instance isn't defined in e2e
@franciscojavierarceo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Elastic Search, QDrant, and PGVector to retrieve_online_documents_v2 method

3 participants