{{ message }}
chore: Offline source image builds, use hermeto generic fetcher for arrow deps#5318
Merged
tchughesiv merged 1 commit intoMay 1, 2025
Merged
chore: Offline source image builds, use hermeto generic fetcher for arrow deps#5318tchughesiv merged 1 commit into
tchughesiv merged 1 commit into
Conversation
Contributor
Sorry, something went wrong.
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
tchughesiv
changed the title
tchughesiv
changed the title
tchughesiv
changed the title
franciscojavierarceo
approved these changes
May 1, 2025
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
Member
There was a problem hiding this comment.
thank you!
Sorry, something went wrong.
jfw-ppi
pushed a commit
to jfw-ppi/feast
that referenced
this pull request
Jun 7, 2025
…rrow deps (feast-dev#5318) chore: Use hermeto generic fetcher for offline arrow source build Signed-off-by: Tommy Hughes <tohughes@redhat.com> Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
With this PR, we no longer have to rely on the arrow third party source download script. Instead, we script & configure the offline hermeto build tool to fetch the source for us.
Which issue(s) this PR fixes:
Relates to #5193
Misc
Moves all offline feature-server image build scripts to
sdk/python/feast/infra/feature_servers/multicloud/offline.If the version of arrow changes in the future... before attempting the offline build,
APACHE_ARROW_VERSIONin the following script would need to be modified and then executed -