◐ Shell
reader mode source ↗
Skip to content

test: Fixed path for milvus tests#5394

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
ntkathole:fix_tests_milvus_path
May 28, 2025
Merged

test: Fixed path for milvus tests#5394
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
ntkathole:fix_tests_milvus_path

Conversation

@ntkathole

@ntkathole ntkathole commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

PR #5382 removed default path for milvus causing failures in integration tests. This PR fixes integration tests by setting path in MilvusOnlineStoreCreator.

ERROR sdk/python/tests/integration/online_store/test_universal_online.py::test_online_retrieval_success[ParameterSet(values=(LOCAL:File:milvus:python_fs:False,), marks=[], id=None)] - pymilvus.exceptions.ConnectionConfigException: <ConnectionConfigException: (code=1, message=uri: localhost:19530 is illegal, needs start with [unix, http, https, tcp] or a local file endswith [.db])>
ERROR sdk/python/tests/integration/online_store/test_universal_online.py::test_retrieve_online_milvus_documents[ParameterSet(values=(LOCAL:File:milvus:python_fs:False,), marks=[], id=None)] - pymilvus.exceptions.ConnectionConfigException: <ConnectionConfigException: (code=1, message=uri: localhost:19530 is illegal, needs start with [unix, http, https, tcp] or a local file endswith [.db])>
ERROR sdk/python/tests/integration/online_store/test_universal_online.py::test_online_retrieval_with_event_timestamps[ParameterSet(values=(LOCAL:File:milvus:python_fs:False,), marks=[], id=None)] - pymilvus.exceptions.ConnectionConfigException: <ConnectionConfigException: (code=1, message=uri: localhost:19530 is illegal, needs start with [unix, http, https, tcp] or a local file endswith [.db])>

@ntkathole
test: Fixed path for milvus tests …
ac32313 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
@ntkathole ntkathole requested a review from a team as a code owner May 28, 2025 04:42
Hide details View details @franciscojavierarceo franciscojavierarceo merged commit c99905d into feast-dev:master May 28, 2025
22 checks passed
jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request Jun 7, 2025
@ntkathole @jfw-ppi
test: Fixed path for milvus tests (feast-dev#5394) …
8ab58ff 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ntkathole @franciscojavierarceo