◐ Shell
reader mode source ↗
Skip to content

test: Add Feast Milvus Jupyter Notebook Execution for downstream testing#5446

Merged
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
Srihari1192:RHOAIENG-24832
Jun 18, 2025
Merged

test: Add Feast Milvus Jupyter Notebook Execution for downstream testing#5446
franciscojavierarceo merged 1 commit into
feast-dev:masterfrom
Srihari1192:RHOAIENG-24832

Conversation

@Srihari1192

@Srihari1192 Srihari1192 commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR introduces automated execution of a Jupyter Notebook as part of downstream testing for the Feast Milvus integration.

  • Added new package e2e_rhoai to scope this test specifically to downstream environments where it's valid and supported. This ensures the test does not interfere with upstream CI.
  • Added supported methods for Notebook creation, fetching notebook pods and monitoring logs for validation
  • Utilizes the Feast RAG Milvus notebook as the basis for end-to-end testing, verifying integration workflows between Feast and Milvus in a real-world example.

Misc

Successfully ran the test locally against an OpenShift cluster — the notebook was deployed and executed as intended, with logs confirming proper operation.

@Srihari1192 Srihari1192 requested a review from a team as a code owner June 11, 2025 07:33
@redhatHameed

redhatHameed commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

can we recreate the issue here/upstream and remove using internal Jira?

@Srihari1192 Srihari1192 requested a review from ntkathole June 16, 2025 11:22
@Srihari1192

Srihari1192 commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

@jyejare @franciscojavierarceo @tchughesiv Can you take a look on this

jyejare
jyejare reviewed Jun 16, 2025
View reviewed changes

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Some comments with One quick question?

  1. Where are we limiting this from running in upstream ?

@Srihari1192

Srihari1192 commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Some comments with One quick question?

  1. Where are we limiting this from running in upstream ?

@jyejare Thank for reviewing We are limiting the execution by isolating the tests under a dedicated package named e2erhoai. This ensures they don’t get picked up by other upstream workflows or general E2E test runs

@Srihari1192 Srihari1192 requested a review from jyejare June 17, 2025 06:42
ntkathole
ntkathole approved these changes Jun 17, 2025
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good!

Hide details View details @franciscojavierarceo franciscojavierarceo merged commit 8a37bf5 into feast-dev:master Jun 18, 2025
19 checks passed
iamcodingcat pushed a commit to iamcodingcat/feast that referenced this pull request Jun 25, 2025
@Srihari1192 @iamcodingcat
test: Add Feast Milvus Jupyter Notebook Execution for downstream test… …
9e7096b 
…ing (feast-dev#5446)

Signed-off-by: Srihari <svenkata@redhat.com>
Signed-off-by: iamcodingcat <joyh951021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole

+1 more reviewer

@jyejare jyejare jyejare approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Srihari1192 @redhatHameed @jyejare @ntkathole @franciscojavierarceo