◐ Shell
reader mode source ↗
Skip to content

feat: Allow hyphen in repo name#5562

Merged
HaoXuAI merged 7 commits into
masterfrom
allow-hyphen-name
Aug 20, 2025
Merged

feat: Allow hyphen in repo name#5562
HaoXuAI merged 7 commits into
masterfrom
allow-hyphen-name

Conversation

@HaoXuAI

@HaoXuAI HaoXuAI commented Aug 10, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

@HaoXuAI HaoXuAI requested a review from a team as a code owner August 10, 2025 16:51
@franciscojavierarceo

franciscojavierarceo commented Aug 10, 2025

Copy link
Copy Markdown
Member

@HaoXuAI take a look at the integration test. Looks like this constraints is requierd.

@HaoXuAI HaoXuAI changed the title feat: Allow hyphen in repo nam Aug 10, 2025
@ntkathole

ntkathole commented Aug 11, 2025

Copy link
Copy Markdown
Member

We will have to change the operator regex as well to be consistent with SDK - https://github.com/feast-dev/feast/blob/master/infra/feast-operator/api/v1alpha1/featurestore_types.go#L71

@HaoXuAI HaoXuAI requested a review from a team as a code owner August 11, 2025 06:25
@HaoXuAI HaoXuAI force-pushed the allow-hyphen-name branch from 4e17dd5 to 8f62ebd Compare August 11, 2025 06:26
HaoXuAI added 5 commits August 10, 2025 23:27
@HaoXuAI
allow hyphen in repo nam …
1c4c2d6 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
@HaoXuAI
fix unit test …
833f895 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
@HaoXuAI
fix unit test …
5834b5b 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
@HaoXuAI
fix int test …
f1c14ae 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
@HaoXuAI
fix readme …
959fc42 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
@HaoXuAI HaoXuAI force-pushed the allow-hyphen-name branch from 8f62ebd to 959fc42 Compare August 11, 2025 06:27
HaoXuAI added 2 commits August 20, 2025 00:10
@HaoXuAI
merge master …
dd68d42 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
@HaoXuAI
fix test …
81b1600 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
ntkathole
ntkathole approved these changes Aug 20, 2025
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good 👍

@HaoXuAI HaoXuAI mentioned this pull request Aug 20, 2025
Closed
Hide details View details @HaoXuAI HaoXuAI merged commit 4436673 into master Aug 20, 2025
20 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Aug 30, 2025
@feast-ci-bot
chore(release): release 0.53.0 …
2f36e7b 
# [0.53.0](v0.52.0...v0.53.0) (2025-08-30)

### Bug Fixes

* Consistency in allow_cache and savedDatasets api ([#5572](#5572)) ([7e8b914](7e8b914))
* **docs:** Use absolute image URLs in README ([7188fc9](7188fc9))

### Features

* Added ray example template ([#5570](#5570)) ([a66d890](a66d890))
* Allow hyphen in repo name ([#5562](#5562)) ([4436673](4436673))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole

@shuchu shuchu Awaiting requested review from shuchu shuchu was automatically assigned from feast-dev/maintainers

@tchughesiv tchughesiv tchughesiv was automatically assigned from feast-dev/maintainers

@lokeshrangineni lokeshrangineni Awaiting requested review from lokeshrangineni lokeshrangineni was automatically assigned from feast-dev/maintainers

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HaoXuAI @franciscojavierarceo @ntkathole