{{ message }}
fix: Correct column list polars materialization engine#5595
Merged
HaoXuAI merged 1 commit intoSep 5, 2025
Merged
Conversation
Contributor
Sorry, something went wrong.
HaoXuAI
approved these changes
Sep 3, 2025
HaoXuAI
left a comment
HaoXuAI
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Collaborator
|
Thanks for contributing! |
Sorry, something went wrong.
Collaborator
|
Need to fix the DCO |
Sorry, something went wrong.
danbaron63
force-pushed
the
fix-correct-column-list-polars-materialization
branch
from
0b3da5d to
1c83d6e
Compare
September 4, 2025 08:39
Contributor
Author
Apologies! Recommitted the last commit, should pass now 🤞 |
Sorry, something went wrong.
…PolarsBackend Signed-off-by: Dan Baron <dan.baron@starlingbank.com>
danbaron63
force-pushed
the
fix-correct-column-list-polars-materialization
branch
from
1c83d6e to
f7e5f88
Compare
September 4, 2025 08:44
Contributor
Author
|
@HaoXuAI any idea why the integration tests are failing for this change? I feel this should be a pretty trivial change 🤔 Thanks! |
Sorry, something went wrong.
Collaborator
seems to be a flaky test, rerunning now. |
Sorry, something went wrong.
Hide details
View details
HaoXuAI
merged commit
HaoXuAI
merged commit 39aeb0c
into
feast-dev:master
Sep 5, 2025
16 of 18 checks passed
Collaborator
|
Thanks for your contributing! |
Sorry, something went wrong.
HaoXuAI
pushed a commit
that referenced
this pull request
Sep 9, 2025
fix: returning the correct column list when requesting columnsin the PolarsBackend Signed-off-by: Dan Baron <dan.baron@starlingbank.com> Signed-off-by: hao-xu5 <hxu44@apple.com>
franciscojavierarceo
pushed a commit
that referenced
this pull request
Sep 30, 2025
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30) ### Bug Fixes * Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71)) * Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c)) * Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6)) * Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d)) * Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56)) * Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006)) * Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022)) * Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1)) * Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754)) * Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e)) * Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4)) ### Features * Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf)) * Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8)) * Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6)) * Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024)) * Added support for image search ([#5577](#5577)) ([56c5910](56c5910)) * Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00)) * Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198)) * Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786)) * Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a)) * Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
Currently materialization fails when using the
PolarsBackendas thecolumnsmethod has no implementation. Worse still, rather than raising aNotImplementedErrorit fails silently by returning nothing which gets interpreted asNone.This provides a valid implementation that allows the
feast materialize ...command to run successfully.Which issue(s) this PR fixes:
N/a
Misc
N/a