{{ message }}
fix: Fixed Registry Cache Refresh Issues#5604
Merged
franciscojavierarceo merged 2 commits intoSep 15, 2025
Merged
Conversation
Member
Sorry, something went wrong.
ntkathole
commented
Sep 10, 2025
ntkathole
force-pushed
the
fix_registry_ttl
branch
2 times, most recently
from
7739f1b to
6b6f2da
Compare
September 10, 2025 07:09
ntkathole
force-pushed
the
fix_registry_ttl
branch
2 times, most recently
from
d53f75a to
2348c85
Compare
September 12, 2025 08:24
Member
|
Test are failing |
Sorry, something went wrong.
ntkathole
force-pushed
the
fix_registry_ttl
branch
4 times, most recently
from
033eba8 to
6220b87
Compare
September 13, 2025 07:37
ntkathole
force-pushed
the
fix_registry_ttl
branch
from
6220b87 to
38ae4dd
Compare
September 15, 2025 06:59
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
ntkathole
force-pushed
the
fix_registry_ttl
branch
from
38ae4dd to
033dfe2
Compare
September 15, 2025 07:07
franciscojavierarceo
approved these changes
Sep 15, 2025
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Hide details
View details
franciscojavierarceo
merged commit
franciscojavierarceo
merged commit 3c7a022
into
feast-dev:master
Sep 15, 2025
17 checks passed
franciscojavierarceo
pushed a commit
that referenced
this pull request
Sep 30, 2025
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30) ### Bug Fixes * Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71)) * Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c)) * Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6)) * Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d)) * Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56)) * Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006)) * Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022)) * Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1)) * Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754)) * Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e)) * Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4)) ### Features * Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf)) * Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8)) * Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6)) * Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024)) * Added support for image search ([#5577](#5577)) ([56c5910](56c5910)) * Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00)) * Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198)) * Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786)) * Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a)) * Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
This PR fix the issues with the Feast registry cache refresh mechanism:
proto()method was calling cached methods (list_*) which would trigger cache refresh, creating a circular dependency.is_cache_expired()function with ttl handling.While testing the fix, identified issue with metric api, that's also fixed.
Which issue(s) this PR fixes:
#5601