feat: Add annotations to cronjob CRDs#5701
Conversation
Sorry, something went wrong.
FredericKayser
force-pushed
the
feat/add-annotations-to-cronjob-crds
branch
from
cc7c177 to
4b53c5f
Compare
October 28, 2025 16:35
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for custom annotations on CronJob metadata in the Feast operator's FeatureStore CRD. The change allows users to specify additional Kubernetes annotations that will be applied to CronJob resources created by the operator.
Key Changes:
- Added
annotationsfield to theFeastCronJobschema definition in the CRD
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
FredericKayser
force-pushed
the
feat/add-annotations-to-cronjob-crds
branch
from
399d62c to
01a8854
Compare
October 28, 2025 19:40
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
FredericKayser
force-pushed
the
feat/add-annotations-to-cronjob-crds
branch
from
e01a3fb to
be90322
Compare
October 29, 2025 13:45
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
FredericKayser
force-pushed
the
feat/add-annotations-to-cronjob-crds
branch
from
be90322 to
432aab3
Compare
October 29, 2025 13:47
|
@franciscojavierarceo do you have any idea why the CI fails now? The failure doesn't really seem to be related to my changes. |
Sorry, something went wrong.
franciscojavierarceo
merged commit be6e6c2
into
feast-dev:master
Oct 29, 2025
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13) ### Bug Fixes * Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2)) * Materialize API - ODFV views not looked-up (thinks views non existant) - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3)) * Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756)) * Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed)) ### Features * Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2)) * Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb)) * Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72)) * Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
What this PR does / why we need it:
This PR adds support for custom annotations on the CronJob resource in the FeatureStore CRD. This enhancement allows users to specify Kubernetes annotations for CronJobs deployed by the Feast operator, which is useful for:
The annotations field has been added to both the spec and status sections of the CronJob definition in the FeatureStore CRD.