◐ Shell
reader mode source ↗
Skip to content

fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore#5703

Merged
ntkathole merged 6 commits into
feast-dev:masterfrom
aniketpalu:RHOAIENG-32904
Nov 3, 2025
Merged

fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore#5703
ntkathole merged 6 commits into
feast-dev:masterfrom
aniketpalu:RHOAIENG-32904

Conversation

@aniketpalu

@aniketpalu aniketpalu commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Problem

  • get_historical_features() with start_date/end_date parameters (no entity_df) works in local mode but fails in remote mode with:
    • EntityTimestampInferenceException: Please provide an entity_df with a column named event_timestamp

Root Cause

  • Remote client sends mock table {"key": "mock_key"} when entity_df is None
  • Server treats mock table as valid entity_df, which lacks event_timestamp column
  • Server doesn't forward start_date/end_date to underlying offline store

Changes

  • Client (remote.py):
    • Handle None entity_df in _create_retrieval_metadata() and _get_entity_schema()
  • Server (offline_server.py):
    • Detect and discard mock tables (single 'key' column)
    • Create minimal entity_df with event_timestamp from start_date/end_date
    • Forward start_date/end_date kwargs to underlying offline store
    • Use pd.to_datetime() and utils.make_tzaware() for proper timestamp types

Which issue(s) this PR fixes:

Misc

@aniketpalu @ntkathole
Added start_date & end_date range for historical data retrieval from … …
b8a8ab6 
…RemoteOfflineStore

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu @ntkathole
Minor linting & reformatting changes …
d6bb773 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Fixed minor issue of empty df with only key as column being trated as… …
0e17fdf 
… entity_df in offline server

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu aniketpalu requested a review from a team as a code owner October 29, 2025 05:45
ntkathole
ntkathole approved these changes Oct 30, 2025
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good! @aniketpalu can you please rebase to resolve conflicts ?

jyejare
jyejare suggested changes Nov 2, 2025
View reviewed changes

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Handle empty entity_df in offline server.

@aniketpalu
Removed unnecessary logic to create mock df …
0d52d17 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu
Minor linting & formatting changes …
4bf7de7 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
@aniketpalu aniketpalu requested a review from jyejare November 3, 2025 11:11
Hide details View details @ntkathole ntkathole merged commit ad32756 into feast-dev:master Nov 3, 2025
17 checks passed
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0 …
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

+1 more reviewer

@jyejare jyejare jyejare approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aniketpalu @jyejare @ntkathole @franciscojavierarceo