◐ Shell
reader mode source ↗
Skip to content

feat: Add possibility to materialize only latest values, to increase performance#5713

Merged
franciscojavierarceo merged 9 commits into
feast-dev:masterfrom
astronautas:feat/add-selective-deduplicate-pushdown-to-offline-store
Nov 11, 2025
Merged

feat: Add possibility to materialize only latest values, to increase performance#5713
franciscojavierarceo merged 9 commits into
feast-dev:masterfrom
astronautas:feat/add-selective-deduplicate-pushdown-to-offline-store

Conversation

@astronautas

@astronautas astronautas commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds an option to materialize only the latest values (essentially pushes down deduplication to offline store), to reduce client memory consumption and reduce e2e duration. Especially noticeable for large-scale materialization - think hundreds of thousands of rows with ~150 feature views, with latency-critical materializations - as we observed in our ML project at cast.ai.

Which issue(s) this PR fixes:

#5707 (comment)

Misc

This will be configured via feature store (repo) config file:

registry: registry.db
project: credit_scoring_aws
provider: local
online_store:
  type: sqlite
offline_store:
  type: file
entity_key_serialization_version: 3
materialization: # <- new option here
  pull_latest_features: true | false (default)

@astronautas astronautas requested a review from a team as a code owner November 5, 2025 11:29
@astronautas

astronautas commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

@HaoXuAI

@astronautas

astronautas commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo

@astronautas
enforce non optional params …
42f9c1b 
Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>
@astronautas
Merge branch 'feat/add-selective-deduplicate-pushdown-to-offline-stor… …
57e91df 
…e' of github.com:astronautas/feast into feat/add-selective-deduplicate-pushdown-to-offline-store
@astronautas astronautas mentioned this pull request Nov 5, 2025
Closed
@astronautas

astronautas commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

Let's re-run tests? Random issue, but no changes to dependency management :/

@astronautas

astronautas commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author
image

Dependency install was skipped :what:

@astronautas

astronautas commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

seems like aws creds have expired @franciscojavierarceo

@franciscojavierarceo

franciscojavierarceo commented Nov 5, 2025

Copy link
Copy Markdown
Member

@ntkathole @jeremyary can you investigate?

HaoXuAI
HaoXuAI reviewed Nov 5, 2025
View reviewed changes

@HaoXuAI HaoXuAI left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I think it might be better to add the config to the fs.materialize API? So that you can customize the materialize process that materialize the FeatureView if you need pushdown filter, and some other process you don't need.

@astronautas

astronautas commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

I think it might be better to add the config to the fs.materialize API? So that you can customize the materialize process that materialize the FeatureView if you need pushdown filter, and some other process you don't need.

Why not indeed. I'll check it out and tag you back.

Hide details View details @franciscojavierarceo franciscojavierarceo merged commit 8d77b72 into feast-dev:master Nov 11, 2025
17 of 18 checks passed
HaoXuAI pushed a commit that referenced this pull request Nov 12, 2025
@astronautas @HaoXuAI
feat: Add possibility to materialize only latest values, to increase … …
673354c 
…performance (#5713)

* add pull_all_from_table_or_query for clickhouse, to align with new materialization logic (calling it)

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>

* add option to select to materialize only latest values, for performance

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>

* enforce non optional params

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>

---------

Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>
Co-authored-by: Lukas Valatka <lukas@valatka.net>
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0 …
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoXuAI HaoXuAI HaoXuAI left review comments

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astronautas @franciscojavierarceo @HaoXuAI