feat: Add integration tests for dbt import with local dbt project#5877
feat: Add integration tests for dbt import with local dbt project#5877Copilot wants to merge 8 commits into
Conversation
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
YassinNouh21
left a comment
There was a problem hiding this comment.
Found several API mismatches that will cause test failures
Sorry, something went wrong.
|
@franciscojavierarceo Found some issues in this PR that need attention: Critical bugs (will cause test failures):
Architecture concerns:
The inline comments on lines 191, 215, 488 show the exact fixes needed for the critical bugs. Happy to help if you need clarification on any of these. |
Sorry, something went wrong.
|
@YassinNouh21 you have to tag |
Sorry, something went wrong.
|
@franciscojavierarceo I thought he will continue working on it 😂 |
Sorry, something went wrong.
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
…generate it Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Fixed in commit 586f825. The issue was an incorrectly pre-committed manifest.json from unit tests (with wrong project name "sample_dbt_project" instead of "feast_integration_test"). The manifest is now generated fresh by |
Sorry, something went wrong.
What this PR does / why we need it:
Adds comprehensive integration tests for the dbt import feature (PR #5827), which previously lacked end-to-end testing with actual dbt project setup and Feast CLI integration.
Changes
Test Infrastructure
sdk/python/tests/integration/dbt/with 600+ lines covering:feast,ml,recommendations)Test dbt Project
test_dbt_project/with 3 models:driver_features: INT types, multiple tagscustomer_features: STRING entityproduct_features: FLOAT32, tag filtering testref()to reference seeds, enabling full dbt workflow testingdbt buildto ensure tests validate actual dbt outputCI/CD - End-to-End Workflow
dbt-integration-tests.ymlmake install-python-dependencies-ci)dbt deps,dbt build,dbt testwith seed datafeast dbt importcommand with generated manifestBug Fixes
PytestUnhandledCoroutineWarningfrom pytest.iniTest Example
Which issue(s) this PR fixes:
Related to #3335
Misc
Comprehensive documentation added for test structure and dbt project. The workflow now provides complete end-to-end testing from dbt model definition through to Feast feature store integration, including actual data materialization to SQLite online store. The manifest.json is dynamically generated during CI to ensure tests validate real dbt compilation output.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.