feat: Making feast vector store with open ai search api compatible#6121
feat: Making feast vector store with open ai search api compatible#6121patelchaitany wants to merge 3 commits into
Conversation
e45f167 to
c8392a9
Compare
March 23, 2026 11:17
7e8adfb to
3f541ad
Compare
March 24, 2026 11:29
cd692b9 to
086bed5
Compare
March 30, 2026 12:05
086bed5 to
9778002
Compare
March 30, 2026 12:51
68c843c to
e29e557
Compare
March 31, 2026 07:05
f0552c7 to
dafe9fd
Compare
March 31, 2026 09:26
e7ba622 to
502286f
Compare
May 14, 2026 11:26
|
Also add documentation for OpenAI-compatible Vector search endpoint in docs/reference/alpha-vector-database.md and docs/reference/feature-servers/python-feature-server.md Also, missing docs for how user can use different embedding provider other than litellm |
Sorry, something went wrong.
502286f to
925eb2e
Compare
May 15, 2026 05:49
925eb2e to
c2782f5
Compare
May 15, 2026 06:31
ntkathole
left a comment
There was a problem hiding this comment.
looks good to me!
@franciscojavierarceo will you be able to take a look once?
Sorry, something went wrong.
|
@ntkathole, The CI for the mcp-feature-server-runtime was failing because fastapi_mcp does not handle circular references properly. To fix this, I made changes in mcp_server.py where we inserted a custom schema resolver that handles how reference schemas are resolved. I also verified its logic against the original fastapi_mcp logic -- both produce the same output when there are no self-referencing schemas. |
Sorry, something went wrong.
58dcb47 to
ba5ad00
Compare
May 20, 2026 11:19
ba5ad00 to
180d80f
Compare
May 21, 2026 05:05
franciscojavierarceo
left a comment
There was a problem hiding this comment.
can you generate an RFC out of this please? 🙏
Sorry, something went wrong.
|
@franciscojavierarceo, I have created an RFC as you requested Docs |
Sorry, something went wrong.
Signed-off-by: Chaitany patel <patelchaitany93@gmail.com>
Signed-off-by: Chaitany patel <patelchaitany93@gmail.com>
…gistration fastapi_mcp 0.4.0 resolve_schema_references() has no cycle detection. Feast's OpenAPI schema contains self-referential protobuf types (Value -> Struct -> Value) which trigger a RecursionError. The error is silently caught, so the /mcp route never gets registered and CI gets a 404. Add _resolve_schema_references_safe() that tracks a seen-refs set to break circular chains, and monkey-patch it into fastapi_mcp before FastApiMCP processes the schema. Non-circular schemas produce identical output to the original. Signed-off-by: Chaitany patel <patelchaitany93@gmail.com>
|
@franciscojavierarceo, let me know if you need any more changes, or if this is good to go. |
Sorry, something went wrong.
What this PR does / why we need it:
This PR making the feast vector store api with open ai search api compatible so.
This are the changes are made.
POST /v1/vector_stores/{vector_store_id}/searchthat matches the OpenAI vector store search APIvector_store_idjust maps to a feature view nameretrieve_online_documents_v2, and returns results in OpenAI'svector_store.search_results.pageformatfeature_store.yamlunder a newembedding_modelsection (model, api_key, api_base, api_version, dimensionsfilter_models.pywith two Pydantic models:ComparisonFilter(eq, ne, gt, gte, lt, lte, in, nin) andCompoundFilter(and/or, nestable)field == 'value'entity_key IN (SELECT ...)enable_openai_compatible_storeconfig flag on every store backendvalue_numcolumn that stores int, float, double, and bool values natively alongside the existing `value_textvalueinstead ofvalue_textqueryparam renamed toembeddingsince that's what it actually isWhich issue(s) this PR fixes:
#5615
Misc