{{ message }}
feat: Add feature view versioning support to Redis and DynamoDB online stores#6257
Merged
ntkathole merged 6 commits intoApr 13, 2026
Merged
Conversation
Collaborator
Sorry, something went wrong.
…e stores Redis: Add _versioned_fv_name() helper that computes versioned feature view names (e.g. driver_stats_v2) used in hash field keys (_ts: and mmh3 feature hashes). This ensures version isolation within the same entity hash key. DynamoDB: Modify _get_table_name() to apply version suffix before template formatting, so each version gets its own DynamoDB table. Both stores are registered in _check_versioned_read_support() and the error message is updated accordingly. Closes feast-dev#6164, closes feast-dev#6163 Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
YassinNouh21
requested review from
dmartinol,
ejscribner and
robhowley
and removed request for
a team
April 10, 2026 11:25
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
YassinNouh21
requested review from
ntkathole
and removed request for
dmartinol,
ejscribner and
robhowley
April 10, 2026 12:52
ntkathole
reviewed
Apr 11, 2026
ntkathole
reviewed
Apr 11, 2026
…sioning gate Redis and DynamoDB modules raise FeastExtrasDependencyImportError (not ImportError) when their dependencies are missing. Use broad Exception catch so environments without redis/boto3 don't break. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Move version resolution logic into a shared compute_versioned_name() in helpers.py, reused by Redis, DynamoDB, and compute_table_id(). Addresses reviewer feedback to avoid duplicating version logic. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
ntkathole
approved these changes
Apr 11, 2026
ntkathole
left a comment
ntkathole
left a comment
Member
There was a problem hiding this comment.
looks good
Sorry, something went wrong.
Hide details
View details
ntkathole
merged commit
ntkathole
merged commit edf25af
into
feast-dev:master
Apr 13, 2026
33 of 35 checks passed
korbonits
pushed a commit
to korbonits/feast
that referenced
this pull request
Apr 13, 2026
…e stores (feast-dev#6257) * feat: Add feature view versioning support to Redis and DynamoDB online stores Redis: Add _versioned_fv_name() helper that computes versioned feature view names (e.g. driver_stats_v2) used in hash field keys (_ts: and mmh3 feature hashes). This ensures version isolation within the same entity hash key. DynamoDB: Modify _get_table_name() to apply version suffix before template formatting, so each version gets its own DynamoDB table. Both stores are registered in _check_versioned_read_support() and the error message is updated accordingly. Closes feast-dev#6164, closes feast-dev#6163 Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com> * fix: Add pragma allowlist for dummy moto credentials in DynamoDB test Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com> * fix: Catch Exception instead of ImportError for Redis/DynamoDB in versioning gate Redis and DynamoDB modules raise FeastExtrasDependencyImportError (not ImportError) when their dependencies are missing. Use broad Exception catch so environments without redis/boto3 don't break. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com> * refactor: Extract shared compute_versioned_name helper to helpers.py Move version resolution logic into a shared compute_versioned_name() in helpers.py, reused by Redis, DynamoDB, and compute_table_id(). Addresses reviewer feedback to avoid duplicating version logic. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com> --------- Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com> Signed-off-by: Alex Korbonits <alex@korbonits.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Summary
_versioned_fv_name()helper that computes versioned feature view names (e.g.,driver_stats_v2) used in Redis hash field keys (_ts:prefix and mmh3 feature hashes). This ensures version isolation within the same entity hash key — the Redis key itself (entity-based) does not change, only the hash field namespace._get_table_name()to apply a version suffix before template formatting, so each version gets its own DynamoDB table (e.g.,project.driver_stats_v2)._check_versioned_read_support()and the error message inerrors.pyis updated.Changes
sdk/python/feast/infra/online_stores/redis.py_versioned_fv_name(), updatedelete_table,online_write_batch,online_read,online_read_async,_generate_hset_keys_for_featuressdk/python/feast/infra/online_stores/dynamodb.py_get_table_name()to apply version suffixsdk/python/feast/infra/online_stores/online_store.py_check_versioned_read_support()sdk/python/feast/errors.pytests/unit/.../test_redis_versioning.py_versioned_fv_name, hset key isolation, read supporttests/unit/.../test_dynamodb_versioning.py_get_table_namewith versioning, templates, read supporttests/integration/.../test_redis_versioning.pytests/integration/.../test_dynamodb_versioning.pyTest plan
test_redis_versioning.py,test_dynamodb_versioning.py)projection.version_tagcorrectly routes reads to the right versionruff checkandruff format --checkpass on all changed filesCloses #6164, closes #6163