{{ message }}
feat: Make online_write_batch_size configurable in MaterializationConfig#6268
Merged
ntkathole merged 2 commits intoApr 14, 2026
Merged
Conversation
Contributor
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
cutoutsy
force-pushed
the
feat/configurable-online-write-batch-size
branch
2 times, most recently
from
de8fe04 to
654b5e4
Compare
April 13, 2026 06:15
ntkathole
reviewed
Apr 13, 2026
Member
|
@cutoutsy can we please also have a test case that exercises the batched write path ? |
Sorry, something went wrong.
ntkathole
reviewed
Apr 13, 2026
cutoutsy
force-pushed
the
feat/configurable-online-write-batch-size
branch
from
d653115 to
bff1499
Compare
April 14, 2026 02:27
Contributor
Author
Added two unit tests for the batched write functionality. |
Sorry, something went wrong.
ntkathole
approved these changes
Apr 14, 2026
ntkathole
reviewed
Apr 14, 2026
Signed-off-by: cutoutsy <cutoutsy@gmail.com>
Signed-off-by: cutoutsy <cutoutsy@gmail.com>
ntkathole
force-pushed
the
feat/configurable-online-write-batch-size
branch
from
bff1499 to
8b4ea7a
Compare
April 14, 2026 10:06
Hide details
View details
ntkathole
merged commit
ntkathole
merged commit d41becf
into
feast-dev:master
Apr 14, 2026
22 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
Add a configurable
online_write_batch_sizeoption toMaterializationConfigfor controlling batch size during online store writes.Changes:
online_write_batch_size: Optional[int] = NonetoMaterializationConfigNone(default): write all rows in a single batch (backward compatible)Usage in
feature_store.yaml:This allows users to control memory usage during materialization for large datasets.
Which issue(s) this PR fixes:
Fixes #6160