{{ message }}
fix: Include StreamFeatureView in freshness metric#6269
Merged
ntkathole merged 2 commits intoApr 13, 2026
Merged
Conversation
Contributor
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ntkathole
reviewed
Apr 13, 2026
ntkathole
approved these changes
Apr 13, 2026
ntkathole
left a comment
ntkathole
left a comment
Member
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Hide details
View details
ntkathole
merged commit
ntkathole
merged commit 463f16c
into
feast-dev:master
Apr 13, 2026
21 of 26 checks passed
korbonits
pushed a commit
to korbonits/feast
that referenced
this pull request
Apr 13, 2026
* added stream_fv Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED * nit Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED Signed-off-by: Alex Korbonits <alex@korbonits.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
update_feature_freshness()only calledstore.list_feature_views(), which excluded StreamFeatureView from thefeast_feature_freshness_seconds gauge. This adds store.list_stream_feature_views() so both batch and stream feature views are trackedWhich issue(s) this PR fixes:
Checks
git commit -s)Testing Strategy
Misc