{{ message }}
fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling#6315
Merged
ntkathole merged 8 commits intoMay 1, 2026
Merged
Conversation
1ac60f9 to
e0b1803
Compare
April 26, 2026 13:58
Contributor
Author
|
The UT failures are caused by flaky tests. Can we retry the failed jobs please? Thanks! |
Sorry, something went wrong.
0be5cd6 to
0aec995
Compare
April 28, 2026 06:08
Contributor
Author
|
Hi maintainers, I'm hoping we can get this merged in time for the upcoming release. Let me know if you need any additional context from my end to help with the review. Thanks! |
Sorry, something went wrong.
ntkathole
approved these changes
May 1, 2026
ntkathole
left a comment
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
…stry._sync_feast_metadata_to_projects_table Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…s in SnowflakeRegistry Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…e test targets Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…onnector.connect Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
0aec995 to
00f5869
Compare
May 1, 2026 05:05
Hide details
View details
ntkathole
merged commit
7e66a2e
into
feast-dev:master
May 1, 2026
20 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What this PR does / why we need it:
SnowflakeRegistrycaused by premature attribute access during__init__settype hints — useset()instead of[]for set-typed variables in_sync_feast_metadata_to_projects_tableprivate_key,private_key_path,private_key_passphrase) before passing tosnowflake.connector.connect, preventing unexpected keyword argument errorsSnowflakeRegistrycache methodsproject_idscoping inget_user_metadataanddelete_projectsnowflake_registryfixture to integration registry testsSnowflakeRegistrywith xdist_group isolationsnowflake_registryto CI filter and exclude from non-Snowflake test targetsWhich issue(s) this PR fixes:
Fixes #5204
Checks
git commit -s)Testing Strategy
Misc
Key files changed:
sdk/python/feast/infra/registry/snowflake.py— core bug fixessdk/python/feast/infra/utils/snowflake/snowflake_utils.py— private key kwarg cleanupsdk/python/tests/unit/infra/registry/test_snowflake_registry.py— new unit test suitesdk/python/tests/integration/registration/test_universal_registry.py— integration fixtureMakefile/.github/workflows/— CI configuration for snowflake registry tests