◐ Shell
reader mode source ↗
Skip to content

fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling#6315

Merged
ntkathole merged 8 commits into
feast-dev:masterfrom
jials:fix/snowflake-registry-bugs
May 1, 2026
Merged

fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling#6315
ntkathole merged 8 commits into
feast-dev:masterfrom
jials:fix/snowflake-registry-bugs

Conversation

@jials

@jials jials commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • Fix init ordering and infinite recursion in SnowflakeRegistry caused by premature attribute access during __init__
  • Fix column casing bugs where Snowflake's uppercase column names broke metadata sync
  • Fix set type hints — use set() instead of [] for set-typed variables in _sync_feast_metadata_to_projects_table
  • Remove leftover private key kwargs (private_key, private_key_path, private_key_passphrase) before passing to snowflake.connector.connect, preventing unexpected keyword argument errors
  • Resolve mypy type errors in SnowflakeRegistry cache methods
  • Correct project_id scoping in get_user_metadata and delete_project
  • Add snowflake_registry fixture to integration registry tests
  • Add comprehensive unit tests for SnowflakeRegistry with xdist_group isolation
  • Add snowflake_registry to CI filter and exclude from non-Snowflake test targets

Which issue(s) this PR fixes:

Fixes #5204

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc

Key files changed:

  • sdk/python/feast/infra/registry/snowflake.py — core bug fixes
  • sdk/python/feast/infra/utils/snowflake/snowflake_utils.py — private key kwarg cleanup
  • sdk/python/tests/unit/infra/registry/test_snowflake_registry.py — new unit test suite
  • sdk/python/tests/integration/registration/test_universal_registry.py — integration fixture
  • Makefile / .github/workflows/ — CI configuration for snowflake registry tests

@jials jials requested a review from a team as a code owner April 22, 2026 02:03
devin-ai-integration[bot]

This comment was marked as resolved.

@jials jials marked this pull request as draft April 22, 2026 02:12
@jials jials marked this pull request as ready for review April 22, 2026 07:15
@jials jials force-pushed the fix/snowflake-registry-bugs branch 2 times, most recently from 1ac60f9 to e0b1803 Compare April 26, 2026 13:58
@jials

jials commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

The UT failures are caused by flaky tests. Can we retry the failed jobs please? Thanks!

@jials jials force-pushed the fix/snowflake-registry-bugs branch from 0be5cd6 to 0aec995 Compare April 28, 2026 06:08
@jials

jials commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Hi maintainers, I'm hoping we can get this merged in time for the upcoming release. Let me know if you need any additional context from my end to help with the review. Thanks!

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm

jials added 8 commits May 1, 2026 10:35
…stry._sync_feast_metadata_to_projects_table

Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…s in SnowflakeRegistry

Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…e test targets

Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
…onnector.connect

Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
@ntkathole ntkathole force-pushed the fix/snowflake-registry-bugs branch from 0aec995 to 00f5869 Compare May 1, 2026 05:05
Hide details View details @ntkathole ntkathole merged commit 7e66a2e into feast-dev:master May 1, 2026
20 of 29 checks passed
@jials jials deleted the fix/snowflake-registry-bugs branch May 3, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snowflake Registry does not work

2 participants