fix: Add project filter to apply_data_source and delete_data_source (closes #6206)#6322
Conversation
|
Hi team! Checking in on this PR which fixes the missing project filter in Quick status update:
Happy to address any feedback or make changes. Thanks for your time! |
Sorry, something went wrong.
|
Hi team! 👋 Friendly ping on feast #6322 — this fixes the missing project filter in Status as of today:
Happy to address any feedback! |
Sorry, something went wrong.
|
Hi @franciscojavierarceo — thanks for the approval! 🙏 Just wanted to flag the failing CI check: the only failure is Our changes only touch Would you be able to merge this given that the failure is pre-existing and unrelated to our changes? Happy to provide any additional info if needed. |
Sorry, something went wrong.
|
@mailtoboggavarapu-coder it looks like integration tests are failing for registry related issues from this change |
Sorry, something went wrong.
|
Hi @franciscojavierarceo — thanks for flagging the CI failures! I've investigated and fixed the root cause. Root CauseThe two new test functions ( Since Fix AppliedChanged both new test functions to use CI StatusBoth previously-failing checks now pass:
DCO NoteOne commit ( |
Sorry, something went wrong.
|
@franciscojavierarceo — one last blocker: the DCO check is The cleanest fix is a squash merge — feast already defaults to "Squash and merge", which collapses all commits into one and bypasses the individual commit DCO issue entirely. For context on the CI failures:
Would you be able to squash merge when you have a chance? Really appreciate the review! 🙏 |
Sorry, something went wrong.
58184c3 to
8dfbc68
Compare
April 30, 2026 23:50
|
@franciscojavierarceo — DCO is now fixed! ✅ I rebased the branch to clean up the commit history — the unsigned commit has been replaced with a properly signed one. Here's the current state: ✅ DCO — passing (Required check) The PR is ready to merge whenever you are. Thanks again for the approval! 🙏 |
Sorry, something went wrong.
…ixes feast-dev#6206) Filters existing data sources by both name and project in the file registry implementation, fixing cross-project contamination (issue feast-dev#6206). Changes: - apply_data_source: added project-scoped deduplication check - delete_data_source: added project filter to avoid cross-project deletion Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Regression tests for feast-dev#6206: - test_apply_data_source_cross_project_isolation: verifies applying a data source to project_a does not overwrite the same-named source in project_b - test_delete_data_source_project_scoped: verifies delete_data_source only removes the source from the specified project Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Changed parametrize decorators from all_fixtures to [lazy_fixture("local_registry")] for
both new test functions to avoid polluting the session-scoped sqlite_registry fixture.
Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
96562c4
into
feast-dev:master
May 1, 2026
Summary
Fixes cross-project data source contamination in the file registry (issue #6206).
Root cause:
apply_data_sourceonly matched onname, notproject, so applying a data source in project B could overwrite an existing source with the same name in project A.Changes:
apply_data_source: deduplication now checks bothnameANDprojectdelete_data_source: deletion now filters by bothnameANDprojectTests added:
test_apply_data_source_cross_project_isolation: verifies project-scoped deduplicationtest_delete_data_source_project_scoped: verifies project-scoped deletionCloses #6206