{{ message }}
fix: Build embedded UI from local source#6526
Merged
franciscojavierarceo merged 4 commits intoJun 16, 2026
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com> (cherry picked from commit f09aa92)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f89eb23bc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Hide details
View details
franciscojavierarceo
merged commit
76d1a00
into
v0.64-branch
Jun 16, 2026
23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What changed
v0.64-branch.make build-uito build the checked-outui/source and copy the generated build intosdk/python/feast/ui/build.build-ui-localas an alias for the same build path.masterso mocked config does not accidentally mount MCP routes in unit tests.masterREST route registration test simplification so the test verifies router inclusion directly instead of depending on mockedRestRegistryServerconstruction side effects.masterallowlist comment for the OpenLineage placeholder API key sodetect-secrets --all-filespasses on the release branch.Why
feast uipackages the embedded React app fromsdk/python/feast/ui/build. The previous release build target pulled@feast-dev/feast-ui --latestfrom npm, but npm's latest published package is still0.57.0. That stale UI treatsregistryPathas a monolithic registry blob URL, so with the newer Python server generating/api/v1, it requestsGET /api/v1and receives a 404.Building the embedded UI from the repo-local
ui/source keeps the frontend bundle aligned with the REST-backed Python UI server for the 0.64 release branch.The test-only backports are included because
v0.64-branchunit tests use aMagicMockconfig. Without requiringmcp.enabled is True, the mock is truthy and the server mounts MCP routes. After that guard, the route-path assertion still depends on mocked server construction, so this PR also matchesmasterby verifyingregister_all_routesdirectly.The OpenLineage manifest change matches
master; it is a placeholder value, not a real secret.Fixes #6519.
Validation
make -n build-uipython3 -m py_compile sdk/python/tests/unit/api/test_api_rest_registry_server.py sdk/python/feast/api/registry/rest/rest_registry_server.pyI could not run the full UI build locally because
yarnis not installed in this shell. I also could not run the targeted Python test locally becauseuvis not installed in this shell, and I could not runpre-commitlocally becausepre-commitis not installed in this shell.