feat: New zoned timestamp feature type (#6536)#6537
Conversation
Sorry, something went wrong.
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
There was a problem hiding this comment.
can you update the PR description?
Sorry, something went wrong.
Sure! @franciscojavierarceo , I noticed that devin is no longer intregrated into PRs. |
Sorry, something went wrong.
|
yeah i need to tune it because we burned through our quota too quickly 😓 |
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7243418383
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Address Codex review findings on PR feast-dev#6537: - Serialize ZonedTimestamp as an ISO 8601 string in feature_server_utils and proto_json so JSONResponse can encode zoned-timestamp features (the raw protobuf message is not JSON-serializable). - Reject ZonedTimestamp as an Array/Set base type, since there is no ZONED_TIMESTAMP_LIST/_SET ValueType for to_value_type() to resolve. - Preserve fixed-offset zones (e.g. UTC-07:00) on decode instead of silently falling back to UTC and shifting the wall-clock time. - Resolve 'ZONED_TIMESTAMP' (and 'SCALAR_MAP') in _convert_value_type_str_to_value_type so registry REST/codegen no longer render the type as String. Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
Reviewers
Assignees
3 participants
Adding new zoned timestamp feature type that stores both timestamp (int64) and zone info (str). If zone is UTC, it only stores timestamp. This is similar to ZonedDateTime in java. This proto type will map to
datetimewith zoneinfo to load for configured zone. For example,