◐ Shell
reader mode source ↗
Skip to content

Reorder package.svg to fix the icon when filled#1275

Open
remi-marchand-zip wants to merge 1 commit into
feathericons:mainfrom
remi-marchand-zip:bugfix/reorder-package-svg-to-fix-fill
Open

Reorder package.svg to fix the icon when filled#1275
remi-marchand-zip wants to merge 1 commit into
feathericons:mainfrom
remi-marchand-zip:bugfix/reorder-package-svg-to-fix-fill

Conversation

@remi-marchand-zip

@remi-marchand-zip remi-marchand-zip commented Sep 17, 2025

Copy link
Copy Markdown

I noticed that when the package icon is 'filled', the top bit of the box is covered up, making it look like the box icon. Example:

Screenshot 2025-09-17 at 11 03 26 AM

By re-ordering the svg elements, the icon remains the same but fill works. Example:

Screenshot 2025-09-17 at 11 06 12 AM

Change:

diff --git a/icons/package.svg b/icons/package.svg
index 1349a8d..ae4c094 100644
--- a/icons/package.svg
+++ b/icons/package.svg
@@ -1 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
- <line x1="16.5" y1="9.4" x2="7.5" y2="4.21"/>
  <path d="M21 16V8a2 2 0 0 0-1-1.73l-7-4a2 2 0 0 0-2 0l-7 4A2 2 0 0 0 3 8v8a2 2 0 0 0 1 1.73l7 4a2 2 0 0 0 2 0l7-4A2 2 0 0 0 21 16z"/>
  <polyline points="3.27 6.96 12 12.01 20.73 6.96"/>
  <line x1="12" y1="22.08" x2="12" y2="12"/>
+ <line x1="16.5" y1="9.4" x2="7.5" y2="4.21"/>
</svg>

Test plan

I tested the icon by checking how it looked in its default state (fill="none") before and after. I then tested again with a fill that I added (fill="yellow") to confirm that I fixed it.

@changeset-bot

changeset-bot Bot commented Sep 17, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 995640c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colebemis colebemis Awaiting requested review from colebemis colebemis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@remi-marchand-zip