{{ message }}
ref(node): Streamline koa#21554
Open
nicohrubec wants to merge 1 commit into
Open
Conversation
Member
Sorry, something went wrong.
Contributor
size-limit report 📦
|
Sorry, something went wrong.
nicohrubec
force-pushed
the
ref/streamline-koa
branch
4 times, most recently
from
89e7d4b to
fffbf52
Compare
June 16, 2026 07:07
Migrate koa span creation to the @sentry/core API, fold the op/origin/name/transaction-name requestHook into span creation, and remove the vendored files' eslint-disable + no-explicit-any exemption. Extend the node-koa e2e for RegExp/nested routers, middleware dedup, and errored-span status, and port the isLayerIgnored unit test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
ref/streamline-koa
branch
from
fffbf52 to
a444a94
Compare
June 16, 2026 07:16
nicohrubec
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
June 16, 2026 07:58
JPeer264
approved these changes
Jun 16, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
nice
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Streamlines the vendored
@opentelemetry/instrumentation-koa:startSpan.requestHookdirectly into the instrumentation'sstartSpancall, and dropped the now-unusedrequestHooklogic/types.isLayerIgnoredfrom otel.kLayerPatched), and errored layer-span status.no-explicit-anyexemption (any→ typed/unknown).Closes #20734